Last modified: 2013-08-03 01:24:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54483, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52483 - TemplateData: Fix "TypeError: Cannot read property 'content' of undefined" (when applying template changes)
TemplateData: Fix "TypeError: Cannot read property 'content' of undefined" (w...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-15
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-02 22:33 UTC by Krinkle
Modified: 2013-08-03 01:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-08-02 22:33:24 UTC 
Looks like we don't account for the API returning an error in ve.ce.MWTransclusionNode.prototype.generateContents. Unconditionally response.visualeditor.content is accessed.

API has a clear path both for dieUsage() and result === success.
Comment 1 Gerrit Notification Bot 2013-08-02 22:35:53 UTC 
Change 77460 had a related patch set uploaded by Krinkle:
ve.ce.MWTransclusionNode: Check for API errors

https://gerrit.wikimedia.org/r/77460
Comment 2 Gerrit Notification Bot 2013-08-03 01:19:18 UTC 
Change 77460 merged by jenkins-bot:
ve.ce.MWTransclusionNode: Check for API errors

https://gerrit.wikimedia.org/r/77460
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links