Last modified: 2014-02-12 23:46:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54494, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52494 - Special:MobileDiff highlights whole paragraph even if edit changed one word only
Special:MobileDiff highlights whole paragraph even if edit changed one word only
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Max Semenik
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-03 04:30 UTC by Qiyue2001
Modified: 2014-02-12 23:46 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
the file shows the effects of a modification on the mobile view and on the desktop view (1.39 MB, image/jpeg)
2013-08-05 02:56 UTC, Qiyue2001
Details

Description Qiyue2001 2013-08-03 04:30:31 UTC

    
Comment 1 Andre Klapper 2013-08-03 13:00:42 UTC
Hi Qiyue2001, 
unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the problem, please read https://www.mediawiki.org/wiki/How_to_report_a_bug and add a more useful description to this report, by providing more information than a short summary line so developers could actually try to reproduce the problem.
Comment 3 Andre Klapper 2013-08-06 12:27:51 UTC
Thanks for the screenshot. What exactly is the bug? 
(What did you expect to see, but did not see?)
Comment 4 Qiyue2001 2013-08-07 01:00:13 UTC
Here's another example: https://en.m.wikipedia.org/wiki/Special:MobileDiff/567442541, it seems changed a lot, but in fact just changed one word:https://en.wikipedia.org/w/index.php?title=Don%27t_be_evil&curid=1788196&diff=567442541&oldid=567442475.
Comment 5 Jon 2013-08-07 01:07:30 UTC
The existing diffs are known not to be brilliant but we are experimenting with improving this (currently in beta):
See:
https://en.m.wikipedia.org/wiki/Special:MobileDiff/567442541?mobileaction=beta
Comment 6 Brion Vibber 2013-09-27 20:04:56 UTC
Updating summary to clarify that it's paragraphs, not necessarily sections, that get highlighted in full, and bumping up from 'unconfirmed' to 'new'.

As Jon noted in comment 5, a better diff mode is being worked on and is available in the beta mode...

(Should this bug be assigned to someone?)
Comment 7 Jon 2013-09-30 21:41:00 UTC
It sounds like this should be reimplemented in PHP.
Comment 8 Jon 2013-12-23 20:42:29 UTC
Max is working on this.
Comment 9 Quim Gil 2013-12-29 00:27:07 UTC
I love the new mobile diff available in beta mode. Thank you!

The only problem I have found so far is that deletion of single spaces are not marked in any way (that I could see).

For instance, see this diff in desktop:

https://ca.wikipedia.org/w/index.php?title=Anarquisme_a_Espanya&curid=1010721&diff=12614384&oldid=12591573

A bot has removed a bunch of single spaces. However, at 

https://ca.m.wikipedia.org/w/index.php?title=Anarquisme_a_Espanya&curid=1010721&diff=12614384&oldid=12591573

there is no red/deletion mark to be seen.

Should I file a separate bug for this?
Comment 10 Jon 2013-12-30 17:12:17 UTC
Please open a new bug Quim. Thank you!
Comment 11 Jon 2014-01-23 21:13:35 UTC
Fixed by https://gerrit.wikimedia.org/r/108946

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links