Last modified: 2013-09-18 15:19:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54501, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52501 - Object of class DataValues\GeoCoordinateValue could not be converted to string
Object of class DataValues\GeoCoordinateValue could not be converted to string
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
: 53459 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-03 15:52 UTC by Sam Reed (reedy)
Modified: 2013-09-18 15:19 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
dereckson: Backport_to_Stable+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2013-08-03 15:52:57 UTC 
PHP Catchable fatal error:  Object of class DataValues\GeoCoordinateValue could not be converted to string in /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php on line 406

PHP Catchable fatal error:  Object of class DataValues\GeoCoordinateValue could not be converted to string in /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php on line 401



Will get some stack traces
Comment 1 Sam Reed (reedy) 2013-08-03 15:54:05 UTC 
[03-Aug-2013 15:42:57] Catchable fatal error: Object of class DataValues\GeoCoordinateValue could not be converted to string at /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php on line 406
Server: mw1081
Method: GET
URL: http://www.wikidata.org/w/index.php?title=Special:RecentChanges&feed=atom
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php(406): Wikibase\ClaimDifferenceVisualizer::visualizeQualifierChanges()
#1 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php(100): Wikibase\ClaimDifferenceVisualizer->visualizeQualifierChanges(Object(Diff\Diff), Object(Wikibase\Statement))
#2 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/EntityDiffVisualizer.php(143): Wikibase\ClaimDifferenceVisualizer->visualizeClaimChange(Object(Wikibase\ClaimDifference), Object(Wikibase\Statement))
#3 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/EntityDiffVisualizer.php(105): Wikibase\EntityDiffVisualizer->getClaimDiffHtml(Object(Diff\DiffOpChange))
#4 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/repo/includes/EntityContentDiffView.php(154): Wikibase\EntityDiffVisualizer->visualizeDiff(Object(Wikibase\ItemDiff))
#5 /usr/local/apache/common-local/php-1.22wmf12/includes/diff/DifferenceEngine.php(676): Wikibase\EntityContentDiffView->generateContentDiffBody(Object(Wikibase\ItemContent), Object(Wikibase\ItemContent))
#6 /usr/local/apache/common-local/php-1.22wmf12/includes/diff/DifferenceEngine.php(608): DifferenceEngine->getDiffBody()
#7 /usr/local/apache/common-local/php-1.22wmf12/includes/FeedUtils.php(156): DifferenceEngine->getDiff('??? Older revis...', 'Revision as of ...')
#8 /usr/local/apache/common-local/php-1.22wmf12/includes/FeedUtils.php(91): FeedUtils::formatDiffRow(Object(Title), '63427104', '63432065', '20130803154212', '/* wbsetclaim-u...', '')
#9 /usr/local/apache/common-local/php-1.22wmf12/includes/ChangesFeed.php(208): FeedUtils::formatDiff(Object(stdClass))
#10 /usr/local/apache/common-local/php-1.22wmf12/includes/ChangesFeed.php(102): ChangesFeed::generateFeed(Object(ResultWrapper), Object(AtomFeed))
#11 /usr/local/apache/common-local/php-1.22wmf12/includes/specials/SpecialRecentchanges.php(182): ChangesFeed->execute(Object(AtomFeed), Object(ResultWrapper), '20130803154256', Object(FormOptions))
#12 /usr/local/apache/common-local/php-1.22wmf12/includes/SpecialPage.php(631): SpecialRecentChanges->execute(NULL)
#13 /usr/local/apache/common-local/php-1.22wmf12/includes/SpecialPageFactory.php(488): SpecialPage->run(NULL)
#14 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(291): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#15 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(565): MediaWiki->performRequest()
#16 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(458): MediaWiki->main()
#17 /usr/local/apache/common-local/php-1.22wmf12/index.php(55): MediaWiki->run()
#18 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#19 {main}
Comment 2 Sam Reed (reedy) 2013-08-03 15:54:22 UTC 
[03-Aug-2013 15:39:59] Catchable fatal error: Object of class DataValues\GeoCoordinateValue could not be converted to string at /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php on line 401
Server: mw1049
Method: GET
URL: http://www.wikidata.org/w/index.php?title=Q5783&diff=63213825&oldid=63213713
Cookie: uls-previous-languages=%5B%22en%22%5D; wikimedia-SUL-final-CN-general=5; wikibase.acknowledgedentitycopyright.en=By%20clicking%20%22save%22%2C%20you%20agree%20to%20the%20terms%20of%20use%2C%20and%20you%20irrevocably%20agree%20to%20release%20your%20contribution%20under%20the%20CC0%20license.; wikiEditor-0-booklet-help-page=format; centralnotice_bucket=0-4.2; uls-previous-languages=%5B%22en%22%2C%22qqx%22%5D; wikidatawikiUserID=61065; wikidatawikiUserName=Addshore; wikidatawiki_session=cf795476e82a919aa65affa17d79b6b0; centralauth_User=Addshore; centralauth_Session=ab5ee78e785e9bda60d9ac5476ac9cad
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php(401): Wikibase\ClaimDifferenceVisualizer::visualizeQualifierChanges()
#1 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php(100): Wikibase\ClaimDifferenceVisualizer->visualizeQualifierChanges(Object(Diff\Diff), Object(Wikibase\Statement))
#2 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/EntityDiffVisualizer.php(143): Wikibase\ClaimDifferenceVisualizer->visualizeClaimChange(Object(Wikibase\ClaimDifference), Object(Wikibase\Statement))
#3 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/lib/includes/EntityDiffVisualizer.php(105): Wikibase\EntityDiffVisualizer->getClaimDiffHtml(Object(Diff\DiffOpChange))
#4 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/repo/includes/EntityContentDiffView.php(154): Wikibase\EntityDiffVisualizer->visualizeDiff(Object(Wikibase\ItemDiff))
#5 /usr/local/apache/common-local/php-1.22wmf12/includes/diff/DifferenceEngine.php(676): Wikibase\EntityContentDiffView->generateContentDiffBody(Object(Wikibase\ItemContent), Object(Wikibase\ItemContent))
#6 /usr/local/apache/common-local/php-1.22wmf12/includes/diff/DifferenceEngine.php(608): DifferenceEngine->getDiffBody()
#7 /usr/local/apache/common-local/php-1.22wmf12/includes/diff/DifferenceEngine.php(581): DifferenceEngine->getDiff('<div id="mw-dif...', '<div id="mw-dif...', '')
#8 /usr/local/apache/common-local/php-1.22wmf12/includes/diff/DifferenceEngine.php(401): DifferenceEngine->showDiff('<div id="mw-dif...', '<div id="mw-dif...', '')
#9 /usr/local/apache/common-local/php-1.22wmf12/includes/Article.php(816): DifferenceEngine->showDiffPage(false)
#10 /usr/local/apache/common-local/php-1.22wmf12/includes/Article.php(548): Article->showDiffPage()
#11 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/repo/includes/actions/ViewEntityAction.php(226): Article->view()
#12 /usr/local/apache/common-local/php-1.22wmf12/extensions/Wikibase/repo/includes/actions/ViewEntityAction.php(156): Wikibase\ViewEntityAction->displayEntityContent(Object(Wikibase\ItemContent))
#13 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(439): Wikibase\ViewEntityAction->show()
#14 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#15 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(565): MediaWiki->performRequest()
#16 /usr/local/apache/common-local/php-1.22wmf12/includes/Wiki.php(458): MediaWiki->main()
#17 /usr/local/apache/common-local/php-1.22wmf12/index.php(55): MediaWiki->run()
#18 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#19 {main}
Comment 3 Aude 2013-08-28 08:05:15 UTC 
*** Bug 53459 has been marked as a duplicate of this bug. ***
Comment 4 Aude 2013-08-28 08:05:29 UTC 
Reported by Infovarius in Wikidata project chat:

Somehow the
[http://www.wikidata.org/w/index.php?title=Q5705&diff=cur&oldid=55786041 diff]
cannot be seen. It says: "PHP fatal error in
/usr/local/apache/common-local/php-1.22wmf13/extensions/Wikibase/lib/includes/ClaimDifferenceVisualizer.php
line 401:  Object of class DataValues\GeoCoordinateValue could not be converted
to string"
Comment 5 Dereckson 2013-08-28 11:38:37 UTC 
[ Product move: WikiBase -> DataValues. Adding Jeroen De Dauw as cc. ]

In the DataValues extension, there is no __toString method in the GlobeCoordinateValue class.
Comment 6 Gerrit Notification Bot 2013-08-28 19:11:32 UTC 
Change 81551 had a related patch set uploaded by Aude:
(bug 52501) handle GlobeCoordinateValue in diff display

https://gerrit.wikimedia.org/r/81551
Comment 7 Gerrit Notification Bot 2013-08-29 09:50:29 UTC 
Change 81551 merged by Tobias Gritschacher:
(bug 52501) handle GlobeCoordinateValue in diff display

https://gerrit.wikimedia.org/r/81551
Comment 8 Andre Klapper 2013-09-02 12:52:36 UTC 
(In reply to comment #7)
> Change 81551 merged by Tobias Gritschacher:
> (bug 52501) handle GlobeCoordinateValue in diff display
> 
> https://gerrit.wikimedia.org/r/81551

Merged - can this bug report be closed, or is there more to do?
Comment 9 Aude 2013-09-02 13:39:44 UTC 
the patch is only for the deployment branch.  still needs to be fixed in master
Comment 10 Dereckson 2013-09-02 17:14:30 UTC 
[ Bug metadata fixed according comments 6 to 9 ]
Comment 11 Gerrit Notification Bot 2013-09-05 11:17:27 UTC 
Change 82815 had a related patch set uploaded by Tobias Gritschacher:
(bug 52501) don't break diff when dataValue could not be formatted

https://gerrit.wikimedia.org/r/82815
Comment 12 Gerrit Notification Bot 2013-09-05 11:18:03 UTC 
Change 82815 abandoned by Tobias Gritschacher:
(bug 52501) don't break diff when dataValue could not be formatted

https://gerrit.wikimedia.org/r/82815
Comment 13 Gerrit Notification Bot 2013-09-05 11:19:30 UTC 
Change 82816 had a related patch set uploaded by Tobias Gritschacher:
(bug 52501) don't break diff when dataValue could not be formatted

https://gerrit.wikimedia.org/r/82816
Comment 14 Gerrit Notification Bot 2013-09-05 11:23:30 UTC 
Change 82816 merged by jenkins-bot:
(bug 52501) don't break diff when dataValue could not be formatted

https://gerrit.wikimedia.org/r/82816
Comment 15 Gerrit Notification Bot 2013-09-13 13:58:46 UTC 
Change 84121 had a related patch set uploaded by Aude:
(bug 52501) don't break diff when dataValue could not be formatted

https://gerrit.wikimedia.org/r/84121
Comment 16 Gerrit Notification Bot 2013-09-16 15:02:22 UTC 
Change 84121 abandoned by Aude:
(bug 52501) don't break diff when dataValue could not be formatted

https://gerrit.wikimedia.org/r/84121
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links