Last modified: 2013-11-03 23:14:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54505, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52505 - Contact us URL behavior needs tweak on the English Wikipedia
Contact us URL behavior needs tweak on the English Wikipedia
Status: NEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-03 21:12 UTC by MZMcBride
Modified: 2013-11-03 23:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-08-03 21:12:57 UTC
This is a follow-up to bug 46392.

I tried to switch the contact us URL on the English Wikipedia from being protocol-relative ("//en.wikipedia.org...") to be simply relative ("/wiki/..."). It turns out that the message [[MediaWiki:Contact-url]] is actually re-used, once in the sidebar and once in the page footer and these two uses are currently incompatible with each other.

Either the messages should be split or the parsing behavior should be made identical between the two.

As discussed at <https://en.wikipedia.org/wiki/MediaWiki_talk:Contact-url>, there's no reason this URL should be a protocol-relative URL, except that it's currently the only way in which you can use one message for two purposes. We should just fix this.

By the way, I tried to test this on <https://test2.wikipedia.org>, but it seems the setup is slightly different over there.
Comment 1 MZMcBride 2013-08-03 22:48:12 UTC
I think switching to Skin::makeInternalOrExternalUrl() would work here. I'll wait to see what happens with Gerrit change #77557.
Comment 2 Bartosz Dziewoński 2013-11-03 14:12:31 UTC
That change was merged. What now?
Comment 3 MZMcBride 2013-11-03 23:10:46 UTC
I still agree with myself in comment 0 and comment 1. :-)  We should either have two messages and/or change the parsing behavior to use Skin::makeInternalOrExternalUrl().
Comment 4 Bartosz Dziewoński 2013-11-03 23:14:32 UTC
We should probably just use Skin::makeInternalOrExternalUrl().

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links