Last modified: 2014-11-02 14:03:16 UTC
Bug: In the lang="haskell" mode, any single quotes (apostrophes) are treated as if they were delimiters for a string. Expected: Single quotes should be treated as normal characters used for identifiers.
The effects of this issue in the Haskell Wikibook are nasty [1]. Upstream, here is a bug report [2] and a proposed patch [3], but both were seemingly ignored. [1] For instance, https://en.wikibooks.org/w/index.php?title=Haskell/Understanding_monads/State&oldid=2550766#Implementation_with_Functional_Purity . [2] http://sourceforge.net/p/geshi/bugs/217/ [3] http://sourceforge.net/p/geshi/bugs/219/
Change 86395 had a related patch set uploaded by Ori.livneh: Haskell syntax: omit single quotes from QUOTEMARKS https://gerrit.wikimedia.org/r/86395
Change 86395 merged by Adamw: Haskell syntax: omit single quotes from QUOTEMARKS https://gerrit.wikimedia.org/r/86395
Thank you for the patch! Looking forward to its arrival at Wikibooks.
The change has caused incorrect rendering of double quotes in Char literals. For example, see second snippet in https://en.wikibooks.org/w/index.php?title=Write_Yourself_a_Scheme_in_48_Hours/Parsing&oldid=2627491#Return_Values
Indeed; though we exchanged an issue which shown up often for a less frequently seen one the situation is not ideal. To fix this issue and a few other annoyances, I am working on patches to haskell.php; they will be submitted uptsream.
(In reply to Daniel Mlot from comment #6) > Indeed; though we exchanged an issue which shown up often for a less > frequently seen one the situation is not ideal. To fix this issue and a few > other annoyances, I am working on patches to haskell.php; they will be > submitted uptsream. It looks like these have been done? https://github.com/GeSHi/geshi-1.0/blob/master/src/geshi/haskell.php :)
Change 150622 had a related patch set uploaded by Reedy: Update GeSHi from upstream https://gerrit.wikimedia.org/r/150622
The above patchset was merged and has actually undone this change in our core, but did bring multiple other enhancements. I have created an upstream pull request: https://github.com/GeSHi/geshi-1.0/pull/30 for this particular problem though.
Change 150622 merged by jenkins-bot: Update GeSHi from upstream https://gerrit.wikimedia.org/r/150622
