Last modified: 2013-11-13 20:10:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54525, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52525 - AbuseFilter doesn't disable filters for safety measure, but says it does!
AbuseFilter doesn't disable filters for safety measure, but says it does!
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-04 16:20 UTC by Helder
Modified: 2013-11-13 20:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2013-08-04 16:20:02 UTC
On
https://pt.wikipedia.org/wiki/Special:AbuseFilter/70?uselang=en
There is the following line
----
Flags: Warning: This filter was automatically disabled as a safety measure. It reached the limit of matching more than 5.00% of actions.
----

But a few lines above it has this:
----
Statistics: Of the last 3,518 actions, this filter has matched 2 (0.06%). On average, its run time is 1.99 ms, and it consumes 288 conditions of the condition limit.
----

Obviously, 0.06% < 5.00%, so one of the message is wrong.

Besides, the latest edit to that filter was on 20:33, 15 July 2013, but there is no timestamp indicating when that warning was added. The filter's log has many (correct) detections since the last edit was made:
https://pt.wikipedia.org/wiki/Special:AbuseLog?dir=prev&wpSearchFilter=70&offset=20130715203331&uselang=en
and the option "Enable this filter" is still marked ([x] instead of [ ]), indicating it is indeed enabled.

If the extension indeed disabled the filter, but enabled it again automatically at some point, it should say so. And if it didn't disable the filter, it should not say it is disabled.

The current situation is confusing.
Comment 1 Helder 2013-08-07 11:34:09 UTC
I edited that filter yesterday[1], and now the message is gone. Whatever the underlying problem is, which makes the filter not to be disabled, at least the interface is updated once we edit the filter (but the message shouldn't be displayed in the first place, if the filter is kept enabled...)

[1] https://pt.wikipedia.org/wiki/Special:AbuseFilter/history/70?uselang=en
Comment 2 Helder 2013-11-13 19:52:02 UTC
This happened again with another filter, per
https://pt.wikipedia.org/w/index.php?diff=37362443

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links