Last modified: 2013-10-11 18:21:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54552, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52552 - Change the order of the "edit" (VE) and "edit source" (WT) tabs on hewiki to have WT as primary
Change the order of the "edit" (VE) and "edit source" (WT) tabs on hewiki to ...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: James Forrester
https://he.wikipedia.org/wiki/%D7%A9%...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-05 16:46 UTC by Eran Roz
Modified: 2013-10-11 18:21 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Eran Roz 2013-08-05 16:46:53 UTC
Users are requesting VE August update (https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/August_2013_update) to be deployed in on hewiki.
Comment 1 matanya 2013-08-05 16:57:07 UTC
Please mark the targeted milestone when it is known. Thanks
Comment 2 Andre Klapper 2013-08-06 12:16:22 UTC
(In reply to comment #0)
> Users are requesting VE August update
> (https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/August_2013_update) to
> be deployed in on hewiki.

Please provide a link to these requests, if possible.
Comment 3 matanya 2013-08-06 12:40:47 UTC
added in the url field.
Comment 4 This, that and the other (TTO) 2013-08-07 07:55:46 UTC
Gerrit change #77269 will handle part of this. They were just waiting on translations of the messages before enabling it.
Comment 5 Eran Roz 2013-08-18 17:48:28 UTC
is there any progress with the request?
Comment 6 James Forrester 2013-08-19 21:45:52 UTC
Hey,

Which of the bits of the update do you mean?

1. The re-ordered tabs and section edit links, so that the VE tab is second?
2. Giving a welcome message when you open VisualEditor for the first time?
3. Adding "beta" as a suffix after the VisualEditor tab and section edit link?
4. Changing "edit" to "edit source" on non-VisualEditor pages for consistency?
5. Removing the animation on section edit links?

All of these? Items 4 and 5 are already done.
Comment 7 Eran Roz 2013-08-20 17:48:29 UTC
All of these
Comment 9 Eran Roz 2013-09-02 18:39:14 UTC
We are now in September so enough time have passed since August change, and the community have voted for deploying the changes. Please let us know when this change is planned for deployment.
Comment 10 James Forrester 2013-09-09 23:47:45 UTC
[Sorry for the delay in responding.]

The beta welcome message is now queued up to go out on all wikis with the next release when available.

We're still not decided on the way forward for the edit source/edit labelling split, so this is delayed until we have a proper answer. Sorry.
Comment 11 Gerrit Notification Bot 2013-09-11 19:28:26 UTC
Change 77269 merged by jenkins-bot:
Enable VisualEditor beta welcome notice for all wikis

https://gerrit.wikimedia.org/r/77269
Comment 12 Eran Roz 2013-10-04 10:37:21 UTC
Thanks for adding the welcome message. 

I know there are discussions regarding these changes[1], but the change of the tab order (Edit and Edit source) is important for he wikipedia and Erik isn't totally against it [only ambivalent] :)

Since VE is enabled only in the main NS and user NS, for editors who also edit in other namespaces, addition of the VE edit tab "in the middle" may cause confusion. For consistency the edit source option should be alway the first option [in order], while VE edit should be second.

----
[1] http://lists.wikimedia.org/pipermail/wikitech-ambassadors/2013-September/000419.html
Comment 13 James Forrester 2013-10-05 01:47:41 UTC
(In reply to comment #12)
> Thanks for adding the welcome message. 
> 
> I know there are discussions regarding these changes[1], but the change of
> the tab order (Edit and Edit source) is important for he wikipedia and Erik
> isn't totally against it [only ambivalent] :)
> 
> [1]
> http://lists.wikimedia.org/pipermail/wikitech-ambassadors/2013-September/
> 000419.html

To speak for Erik (:-)), his ambivalence is about changing it *globally*, not about changing it on a given wiki.

There's scope for a lot of concern about changing it for some wikis and not others, and so having a very inconsistent configuration for people that use multiple wikis. I think that it's probably OK to do this, but I really haven't come to "a decision". However, it's unfair to hewiki to have you hanging around waiting for me to make up my mind, and I'm sorry about this. :-(

> Since VE is enabled only in the main NS and user NS, for editors who also
> edit in other namespaces, addition of the VE edit tab "in the middle" may
> cause confusion.

That is certainly one argument. (Though surely it only applies to people with a very narrow window, or the minority who use the Monobook skin? For the others, the VisualEditor tab sits prone in namespaces they can use it in, and otherwise they get the tab they currently have to use until Flow is fully rolled out). But I see your point.

> For consistency the edit source option should be alway the first
> option [in order], while VE edit should be second.

An alternative argument is that it's right that the first and primary tab is always the one they can use, and there may or may not be a secondary editor tab depending on the nature of the content they're editing.

Of course, we can partially 'fix' this by enabling VisualEditor in all the other namespaces that it's safe for (at the least, File, Portal, Category, Help; not Project, as that's normally signed and so should wait with *_Talk for Flow). Not sure.

In the mean time, I'm happy to move hewiki to [ Edit source | Edit ] for the time being, and would really welcome thoughts on my other points above.
Comment 14 Gerrit Notification Bot 2013-10-05 01:57:17 UTC
Change 87645 had a related patch set uploaded by Jforrester:
Switch VisualEditor to secondary status on hewiki

https://gerrit.wikimedia.org/r/87645
Comment 15 James Forrester 2013-10-05 01:58:07 UTC
(In reply to comment #14)
> Change 87645 had a related patch set uploaded by Jforrester:
> Switch VisualEditor to secondary status on hewiki
> 
> https://gerrit.wikimedia.org/r/87645

Will try to schedule this soon.
Comment 16 Gerrit Notification Bot 2013-10-11 18:18:33 UTC
Change 87645 merged by Reedy:
Switch VisualEditor to secondary status on hewiki

https://gerrit.wikimedia.org/r/87645
Comment 17 James Forrester 2013-10-11 18:21:29 UTC
Finally done; sorry for the delay.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links