Last modified: 2014-05-05 17:58:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54566, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52566 - VisualEditor: When section edit is initiated with an actual page load, VE does not navigate to the section
VisualEditor: When section edit is initiated with an actual page load, VE doe...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low minor
: VE-deploy-2014-05-08
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-06 00:02 UTC by Spinningspark
Modified: 2014-05-05 17:58 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Spinningspark 2013-08-06 00:02:20 UTC
When VisEd is activated from a section edit link, the focus of the display normally stays on that section.  However, if the user activates from a section edit link while on a diff link (has to be diff of current version), the focus shifts to the top of the page as if the whole page edit link had been pressed.
Comment 1 Matthew Flaschen 2014-05-05 02:47:08 UTC
This is just a special case.  The general issue is that VE does not navigate to the section when a section edit is initiated with a fresh page load (it does when it uses the AJAX switch to editing without a page load).  For example, https://en.wikipedia.org/w/index.php?title=Earth&veaction=edit&section=6 .  It appears in this case because VE (there is a comment to this effect) uses a new page load to start section editing when it's showing the latest diff (to deal with another issue).

This applies any time the user is sent directly to edit a section via VE.  For the Growth team's current project, we will allow the user to click "Sign up and edit" (including for sections).  This works using the normal signup page, with the returnto and returntoquery parameters.  That means we can not do an AJAX switch.

Besides login/signup, there are other (albeit less common) reasons you might want to link directly to a section edit URL.
Comment 2 Gerrit Notification Bot 2014-05-05 03:03:40 UTC
Change 131415 had a related patch set uploaded by Mattflaschen:
Generate PHP VE edit section with correct parameter, vesection

https://gerrit.wikimedia.org/r/131415
Comment 3 James Forrester 2014-05-05 17:57:51 UTC
Thanks, Matt!
Comment 4 Gerrit Notification Bot 2014-05-05 17:58:58 UTC
Change 131415 merged by jenkins-bot:
Generate PHP VE edit section with correct parameter, vesection

https://gerrit.wikimedia.org/r/131415

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links