Last modified: 2014-09-09 18:24:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54611, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52611 - Upload Wizard not respecting default license of user
Upload Wizard not respecting default license of user
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Yuvi Panda
:
: 53574 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-07 13:35 UTC by Ryan Kaldari
Modified: 2014-09-09 18:24 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2013-08-07 13:35:14 UTC
At some point recently, Upload Wizard stopped respecting the default license that the user sets in their user preferences. This is causing images to be uploaded with the wrong license.
Comment 1 Ryan Kaldari 2013-08-07 13:36:51 UTC
Specifically, when the user gets to the "Release rights" step, it seems to be applying the CC-BY-SA license regardless of what license the user has set as their default in their preferences.
Comment 2 Ryan Kaldari 2013-08-07 13:38:58 UTC
The breakage happened sometime between July 15 and August 3.
Comment 3 Ryan Kaldari 2013-08-08 06:24:38 UTC
Looks like this was broken by the campaigns refactoring. Specifically:
https://gerrit.wikimedia.org/r/#/c/72850/
https://gerrit.wikimedia.org/r/#/c/70446/
Comment 4 Andre Klapper 2013-08-15 15:43:37 UTC
mtraceur: Could you take a look at this?
Comment 5 Mark Holmquist 2013-08-15 16:52:24 UTC
Not in the near future, but it was Yuvi's patch, maybe he has a good idea of what went wrong?
Comment 6 Rob Lanphier 2013-08-22 21:14:31 UTC
Yuvi, could you look into this?
Comment 7 Yuvi Panda 2013-08-22 21:15:21 UTC
Just got off vacation, and currently a bit sick. Should be able to in a day or two.
Comment 8 Ryan Kaldari 2013-08-28 00:01:01 UTC
Hey Yuvi, did you ever get a chance to look at this?
Comment 9 Yuvi Panda 2013-08-28 00:08:39 UTC
Whoops, forgot about it and did other stuff. I'll be happy if someone else can, but if not I can hopefully look at this tomorrow?

I'm also surprised by the general lack of pitchforks and torches, considering this could be considered a big bug. But yes, tomorrow.
Comment 10 Gerrit Notification Bot 2013-08-28 01:12:34 UTC
Change 81444 had a related patch set uploaded by MarkTraceur:
Fix bug in campaigns refactor for default licenses

https://gerrit.wikimedia.org/r/81444
Comment 11 Gerrit Notification Bot 2013-08-28 23:23:14 UTC
Change 81444 merged by jenkins-bot:
Fix bug in campaigns refactor for default licenses

https://gerrit.wikimedia.org/r/81444
Comment 12 Mark Holmquist 2013-08-28 23:28:07 UTC
We "fixed" it, it seems to work now, but it won't get deployed for a little bit. I'm going to mark as resolved, but reopen if the patch doesn't fix it on Commons.
Comment 13 Kunal Mehta (Legoktm) 2013-08-30 05:28:13 UTC
*** Bug 53574 has been marked as a duplicate of this bug. ***
Comment 14 Jonatan Svensson Glad (Josve05a) 2014-09-09 18:24:22 UTC
Works for me when I tried it on betacommons. Marking as VERIFIED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links