Last modified: 2014-06-23 19:57:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54618, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52618 - Bad wikitext lines starting with "| " (not in a table context) getting the pipes removed and replaced by <nowiki> </nowiki> on RT
Bad wikitext lines starting with "| " (not in a table context) getting the pi...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-07 21:41 UTC by Elitre
Modified: 2014-06-23 19:57 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Elitre 2013-08-07 21:41:42 UTC
http://en.wikipedia.org/w/index.php?title=National_Security_Intelligence&diff=next&oldid=558880809 - the corruption was later reproduced in a sandbox by Rybec "by copy-pasting the previous revision to a sandbox and editing just the lead paragraph in the same way in VE. The unwanted changes are displayed in the review window", so aside from nowikis, we need to find out why it deletes some bits of the text.

Also adding http://fr.wikipedia.org/w/index.php?title=Romain_Alessandrini&diff=95638901&oldid=95638848 which as the previous one happened after a template was left open. I think this should happen to prevent | signs to be shown as they are usually markup and not really wanted in an article, but I still can see them in View mode, so I need to understand more about this behavior. Thanks.
Comment 1 James Forrester 2013-10-29 00:40:48 UTC
This looks to be a Parsoid "bug", though frankly the behaviour of the system when given such broken input is somewhat undefined.

Minimum test case:

Foo
| Bar
Comment 2 Gabriel Wicke 2013-12-03 23:26:59 UTC
The issue here is that we are tokenizing this to a td token, which is then dropped by the treebuilder when that does not end up inside a table. We should be able to detect this on the DOM based on shadow info. When detected, we can re-insert the original pipe so that it is not lost.

That might not yet avoid the <nowiki> insertion, but would at least preserve the content. It is also possible that selser avoids the nowiki.
Comment 3 Gerrit Notification Bot 2014-02-21 23:35:46 UTC
Change 114897 had a related patch set uploaded by GWicke:
WIP Bug 52618: Rescue stripped tds outside of table context

https://gerrit.wikimedia.org/r/114897
Comment 4 Gerrit Notification Bot 2014-02-25 18:31:24 UTC
Change 114897 merged by jenkins-bot:
Bug 52618: Rescue stripped tds outside of table context

https://gerrit.wikimedia.org/r/114897
Comment 5 Gabriel Wicke 2014-02-25 18:55:33 UTC
TODO from the commit summary:

- Avoid <nowiki>fication on round-trip (even with selser)
- Avoid paragraph splitting by moving the paragraph wrapper to the DOM (major project)
Comment 6 Gerrit Notification Bot 2014-02-25 20:01:27 UTC
Change 115436 had a related patch set uploaded by GWicke:
Bug 52618: Avoid <nowiki>fication of td/tr/th syntax outside of tables

https://gerrit.wikimedia.org/r/115436
Comment 7 Gerrit Notification Bot 2014-02-25 22:20:29 UTC
Change 115436 merged by jenkins-bot:
Bug 52618: Avoid <nowiki>fication of td/tr/th syntax outside of tables

https://gerrit.wikimedia.org/r/115436
Comment 8 Gerrit Notification Bot 2014-06-16 20:36:42 UTC
Change 140015 had a related patch set uploaded by Subramanya Sastry:
(Bug 52618) Suppress <nowiki>s for table WT strings outside tables

https://gerrit.wikimedia.org/r/140015
Comment 9 Gerrit Notification Bot 2014-06-17 23:54:13 UTC
Change 140015 merged by jenkins-bot:
(Bug 52618) Suppress <nowiki>s for table WT strings outside tables

https://gerrit.wikimedia.org/r/140015

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links