Last modified: 2013-08-27 13:22:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54623, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52623 - [TUX] Discard changes only works the second time
[TUX] Discard changes only works the second time
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-08 03:27 UTC by Niklas Laxström
Modified: 2013-08-27 13:22 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2013-08-08 03:27:36 UTC
1) Go to https://translatewiki.net/w/i.php?title=Special:Translate&group=out-eol-0-all&language=sv&filter=&action=translate
2) Open a short message which has suggestions and existing translation
3) Apply a suggestion
4) Click discard changes

Observed: Text gets reverted but button does not disappear until clicked the second time
Expected: Button disappears

Git bisect points to:
commit 7eaee736c75743fc67a4a9c0253fa25a84fb7ef6
Author: Santhosh Thottingal <santhosh.thottingal@gmail.com>
Date:   Tue Apr 9 14:33:51 2013 +0530

    Fix text change detection in IE
    
    Introduce textchange event that get triggered when something changed
    on input fields.
    
    Refactor translation textarea construction. Set the value before
    starting listening to events. Listen events only with one listener.
    Set the two dirty flags together for consistency.
    
    This eliminates the "You have unchanged saves" popup appearing in IE
    even when there were no changes.
    
    This fixes the case when it was impossible to get rid of unsaved
    status for messages which have no existing status.
    
    Bug: 47019
    Bug: 46266
    Change-Id: Ib5a7fecdf3cc42c7f5463bb03cae2326e1a3afbc
Comment 1 Gerrit Notification Bot 2013-08-08 04:13:15 UTC
Change 78190 had a related patch set uploaded by Nikerabbit:
Fix discard button in Chrome

https://gerrit.wikimedia.org/r/78190
Comment 2 Gerrit Notification Bot 2013-08-08 04:43:15 UTC
Change 78190 merged by jenkins-bot:
Fix discard button in Chrome

https://gerrit.wikimedia.org/r/78190

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links