Last modified: 2014-11-05 20:04:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54645, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52645 - VisualEditor: Tool to set/unset text colour
VisualEditor: Tool to set/unset text colour
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
: 51409 (view as bug list)
Depends on:
Blocks: 47780
  Show dependency treegraph
 
Reported: 2013-08-08 10:12 UTC by Chris McKenna
Modified: 2014-11-05 20:04 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-08-08 10:12:37 UTC
VisualEditor needs a tool to set/unset font colour.
Comment 1 James Forrester 2013-08-10 06:12:52 UTC
Do we want to do this as a general colour-picker widget, possibly?
Comment 2 Inez Korczyński 2013-08-10 06:17:41 UTC
Any pros/cons of handling this by wrapping colored text in span with appropriate value of style tag?
Comment 3 James Forrester 2013-08-10 07:44:41 UTC
*** Bug 51409 has been marked as a duplicate of this bug. ***
Comment 4 James Forrester 2013-08-10 08:24:20 UTC
(In reply to comment #2)
> Any pros/cons of handling this by wrapping colored text in span with
> appropriate value of style tag?

Yeah, that's what we'll want to do.

We'll want to supply a generic <span> editor (which lets you edit the style="…" tag as raw CSS) at some point, but we'd want to do something about colour sooner (and nicer), I think.
Comment 5 MZMcBride 2013-10-29 00:54:36 UTC
I think this will be difficult to implement well. I see two concerns:

* extraneous (noöp) <span>s being left behind in the wikimarkup; and
* <span>s that specify the color black (bad for accessibility, etc.).

There may be some generic "clear formatting" button/apparatus to be used to mitigate the second point, but I'm still wary.
Comment 6 James Forrester 2013-10-29 01:09:44 UTC
(In reply to comment #5)
> I think this will be difficult to implement well. I see two concerns:
> 
> * extraneous (noöp) <span>s being left behind in the wikimarkup; and

This is the same as bug 37835 and is trivial for us to trim out.

> * <span>s that specify the color black (bad for accessibility, etc.).

Yes, though we already give people loads of tools that they can (and frequently do) abuse. Technology should serve the community and we should make tools that let them do their job, rather than dictate that they can't do something (or, in this case, that they can but it's hard).

> There may be some generic "clear formatting" button/apparatus to be used to
> mitigate the second point, but I'm still wary.

There's already a "clear formatting" button provided - it would apply its magic to this too.
Comment 7 Helder 2014-05-23 21:37:40 UTC
(Copied from
https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Textcolor)

Hi there :-)
Just wondering, why there is no feature for "coloring Text". In know, there is a way, to use 'span', but im looking for a feature, with a WYSIWYG-Editor. Any advices, ideas?

Thanks :-)
Comment 8 Elitre 2014-11-05 11:51:40 UTC
Would we need to file a separate bug for background text color?
Comment 9 James Forrester 2014-11-05 20:04:30 UTC
(In reply to Elitre from comment #8)
> Would we need to file a separate bug for background text color?

Background colour isn't really a thing we want to encourage. :-) That would be a distinct piece of work; created as bug 73041.

If you meant surface colouring for objects like table cells or <div>s, that's another piece of work again - bug 52180	for table cells, possibly that bug will need to be split for the wider work.

If you mean the "highlight" / "mark" tool, that's yet another one - bug 64376.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links