Last modified: 2013-11-08 00:39:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54694, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52694 - deactivate and decom codereview-proxy
deactivate and decom codereview-proxy
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Subversion (Other open bugs)
wmf-deployment
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-10 06:56 UTC by Daniel Zahn
Modified: 2013-11-08 00:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Zahn 2013-08-10 06:56:23 UTC
23:43 < mutante> can we delete this ?  http://codereview-proxy.wikimedia.org/

23:47 < p858snake|l> mutante: We still want to keep running E:CodeReview afaik
23:47 < p858snake|l> although you need to confirm with chad

23:49 < ori-l> mutante: yes, I think we need it :/
23:50 < mutante> alright, ehem, i had it removed for 5 minutes but restored it 

23:51 < mutante> that means we'll have to migrate it away from Tampa...
23:51 < mutante> or it will disappear $someday
23:51 < Reedy> I think it can go
23:51 < Reedy> / If you can't directly access the remote SVN repo, you can set this
23:51 < Reedy> / to an offsite proxy running this fun little proxy tool:
23:52 < Reedy> As the repos are all now readonly...
23:52 < ori-l> I looked through the code and had a hard time verifying that it is used only for writes
23:52 < ori-l> but I think it'd be fair to just disable it and see what happens
23:53 < ori-l> because even read access is needed only for archival reasons; it's not like anybody's work would be massively disrupted if it went away for a little bit.
23:53 < Reedy> As long as all revisions have a diff in the code_rev table..
23:54 < ori-l> Reedy: we could comment out $wgSubversionProxy in CommonSettings.php
23:54 < ori-l> that's easy to revert
23:54 < ori-l> and if things look alright then decom the service
23:55 < mutante> creates a bug :)
Comment 1 Chad H. 2013-08-10 07:24:22 UTC
While we're at it, let's revoke everyone's coder permissions.
Comment 2 Sam Reed (reedy) 2013-08-10 12:07:16 UTC
From testing, rand() apache can pull files from formey (in EQIAD or PMTPA).

Disabling the proxy stops any uncached (in the database) diffs from being retrieved. I guess the proxy also stops the need to have svn libraries etc installed on every apache across the cluster.

As of writing this comment, there are 1011 revisions without diffs in the database. Originally (earlier today) there were 8725 revisions with a cr_diff of null

I wrote a quick maintenance script to populate the revisions https://gerrit.wikimedia.org/r/#/c/78497/ and am currently running it a few times, with config tweaks to get complete population
Comment 3 Andre Klapper 2013-08-26 10:16:32 UTC
(In reply to comment #2 by Reedy)
> I wrote a quick maintenance script to populate the revisions
> https://gerrit.wikimedia.org/r/#/c/78497/ and am currently running it a few
> times, with config tweaks to get complete population

Reedy: Did that work out well?
Comment 4 Gerrit Notification Bot 2013-10-30 01:36:51 UTC
Change 92606 had a related patch set uploaded by Reedy:
Remove $wgSubversionProxy

https://gerrit.wikimedia.org/r/92606
Comment 5 Sam Reed (reedy) 2013-10-30 01:41:27 UTC
Seems it's broken anyway

http://codereview-proxy.wikimedia.org/index.php takes you to https://bugzilla.wikimedia.org/index.php which doesn't exist

Daniel can find a big stabby knife from somewhere to kill the remains
Comment 6 Gerrit Notification Bot 2013-11-07 18:47:45 UTC
Change 92606 merged by jenkins-bot:
Remove $wgSubversionProxy

https://gerrit.wikimedia.org/r/92606
Comment 7 Daniel Zahn 2013-11-08 00:39:34 UTC
removed from DNS: https://gerrit.wikimedia.org/r/#/c/93761/

cleaned up remnants on kaulen, backup of the old apache site on tridge. i think we can close this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links