Last modified: 2013-08-27 13:58:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54716, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52716 - VisualEditor: cursor places itself after the first character when inserting a group of Japanese characters
VisualEditor: cursor places itself after the first character when inserting a...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Language (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-08-22
Assigned To: D Chan
: i18n
Depends on:
Blocks: ve-multi-lingual
  Show dependency treegraph
 
Reported: 2013-08-11 03:25 UTC by Amir E. Aharoni
Modified: 2013-08-27 13:58 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-08-11 03:25:29 UTC
When you edit captions and input Japanese text with Japanese input method (of ことえり, the default Japanese method of Mac OS X), for example 生醤油 (kijouyu), the cursor will place itself after the first character, but it should place itself after the last (3rd) character. Tested on Firefox and OSX, but may happen in other browsers and operating systems. Thanks to Takashi Ota and Josh Lim for testing and reporting.
Comment 1 Amir E. Aharoni 2013-08-15 16:59:29 UTC
Now I tested it myself on Fedora 18 with Firefox. It happens there too. To reproduce:

1. Enabled the "Japanese (Anthy)" keyboard in GNOME input sources.
2. In a VisualEditor window type "mitsubishi". It appears as four Kana characters: "みつびし".
3. Press the space bar. The four characters change to two Kanji characters: "三菱".
4. Press Enter. This accepts the Kanji representation.

Observed: The cursor is placed between 三 and 菱.
Expected: The cursor should be placed after 三菱. That is what happens in other text editors on my system.
Comment 2 D Chan 2013-08-19 14:28:50 UTC
This seems to be caused by a call to surfaceObserver.stop() in Surface's onDocumentKeyDown method, which is wrongly asynchronous. The same problem was affecting Malayalam and probably other scripts/IMEs too.

I *think* it should be fixed by https://gerrit.wikimedia.org/r/#/c/79451 (just merged).
Comment 3 Amir E. Aharoni 2013-08-19 18:35:58 UTC
Doesn't seem to be happening any more.
Comment 4 James Forrester 2013-08-20 01:09:41 UTC
Patch has been reverted due to other issues, sadly.
Comment 5 Gerrit Notification Bot 2013-08-20 19:40:56 UTC
Change 80080 had a related patch set uploaded by Jforrester:
WIP:Don't emit Surface changes back to the Surface

https://gerrit.wikimedia.org/r/80080
Comment 6 Gerrit Notification Bot 2013-08-22 09:48:51 UTC
Change 80080 merged by jenkins-bot:
Don't emit Surface changes back to the Surface

https://gerrit.wikimedia.org/r/80080
Comment 7 James Forrester 2013-08-22 20:13:16 UTC
Given that this is now merged, I'm going to mark this as fixed. However, this is provisional - please re-open if you think that this has not worked!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links