Last modified: 2014-07-05 13:41:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54732, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52732 - wblinktitles id in api response does not start with a q, it is a raw int id


Summary:	wblinktitles id in api response does not start with a q, it is a raw int id

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	api_breaking_change
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-11 19:10 UTC by Addshore
Modified:	2014-07-05 13:41 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Addshore 2013-08-11 19:10:29 UTC

When performing an action with linktitles the api reports back and ID but it doesn't come in the format 'q123' instead just '123'

Comment 1 Gerrit Notification Bot 2013-08-12 11:03:03 UTC

Change 78521 had a related patch set uploaded by Addshore:
Refactor LinkTitlestest

https://gerrit.wikimedia.org/r/78521

Comment 2 Kunal Mehta (Legoktm) 2013-08-31 09:52:27 UTC

(In reply to comment #1)
> Change 78521 had a related patch set uploaded by Addshore:
> Refactor LinkTitlestest
> 
> https://gerrit.wikimedia.org/r/78521

Patch was merged, is this fixed now?

Comment 3 Addshore 2013-10-10 09:46:31 UTC

The patch doesn't seem to actually touch the LinkTitles class so this is likely still open.

Also changing this will be a breaking change to the api output as anything currently using the module is probably expecting the id without a Q

Comment 4 Lydia Pintscher 2013-10-10 09:49:45 UTC

Do we still need to do this then or should we resolve wontfix? The benefit is unclear to me.

Comment 5 Addshore 2013-10-10 09:54:11 UTC

We should still do this, although we should try and do it at the same time as other breaking changes.
The fix itself is only a line or two.

Comment 6 Gerrit Notification Bot 2014-06-08 02:08:20 UTC

Change 138217 had a related patch set uploaded by Hoo man:
Make wblinktitles return a prefixed id

https://gerrit.wikimedia.org/r/138217

Comment 7 Gerrit Notification Bot 2014-06-09 04:50:46 UTC

Change 138217 merged by Jeroen De Dauw:
Make wblinktitles return a prefixed id

https://gerrit.wikimedia.org/r/138217

Comment 8 Lydia Pintscher 2014-06-09 12:40:32 UTC

Katie: Might need adding to deployment notes and possibly wider announcement?

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links