Last modified: 2013-08-14 23:16:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54751, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52751 - Regression: Wikitext for new lists has unnecessary newlines after bullets


Summary:	Regression: Wikitext for new lists has unnecessary newlines after bullets

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	---
Assigned To:	ssastry

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-12 14:31 UTC by mham
Modified:	2013-08-14 23:16 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Output after saving (6.94 KB, image/png) 2013-08-12 14:31 UTC, mham	Details
Add an attachment (proposed patch, testcase, etc.)

Description mham 2013-08-12 14:31:17 UTC

Created attachment 13088 [details]
Output after saving

My setup:

MediaWiki:
1.22alpha (ffa9b0a) 19:02, 11. Aug. 2013

VisualEditor (Version 0.1.0)(0e76b1b)20:01, 11. Aug. 2013

ParsoidServer:
commit a4fec47e5201c329925967376f4106abd11178e3
Merge: fdb6e06 30315ed Author: jenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Date:   Fri Aug 9 02:43:12 2013 +0000


When I put in a simple Unsorted list the Parsoid Server throws an error message:
Incompatible constraints 1: LI P {a:{min: 0, max: 0}, b:{min: 1, max: 2}, min:0, max 0}


Attached you find the resulting output after I saved the page. Notice the extra Line that got added by Parsoid.

Comment 1 ssastry 2013-08-12 20:54:45 UTC

I suspect this is a regression of some sort.  Can be duplicated with this HTML below (VE wraps li-content in p-tags).

[subbu@earth tests] echo "<ul><li><p>a</p></li></ul>" | node parse --html2wt
Incompatible constraints 1: LI P { a: { min: 0, max: 0 }, b: { min: 1, max: 2 }, min: 0, max: 0 }
* 
a

Comment 2 ssastry 2013-08-12 20:58:05 UTC

git bisect shows that c0de1d5839430e9fde79ff4195caf6841baab0d3 is the culprit.  Will investigate and fix.

Comment 3 Gerrit Notification Bot 2013-08-12 21:18:34 UTC

Change 78913 had a related patch set uploaded by Subramanya Sastry:
(Bug 52751): Serialize p-wrapped list items correctly

https://gerrit.wikimedia.org/r/78913

Comment 4 Gerrit Notification Bot 2013-08-13 20:04:04 UTC

Change 78913 merged by jenkins-bot:
(Bug 52751): Serialize p-wrapped list items correctly

https://gerrit.wikimedia.org/r/78913

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links