Last modified: 2013-09-04 15:19:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54762, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52762 - Treat a line with WS and comments only as being transparent to all handlers
Treat a line with WS and comments only as being transparent to all handlers
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: ssastry
:
: 49974 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-12 18:49 UTC by C. Scott Ananian
Modified: 2013-09-04 15:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description C. Scott Ananian 2013-08-12 18:49:50 UTC
Bug 41756 fixed an old regression in the PHP preprocessor, so that a blank line containing nothing but two or more comments is ignored (does not break lists, etc).

This fix needs to be applied to Parsoid as well.
Comment 1 ssastry 2013-08-12 20:08:29 UTC
I am fixing the p-handler for now since it already had special-case code for the older pattern.  But, a fix for 49974 would be more ideal that is more general.
Comment 2 ssastry 2013-08-12 20:17:25 UTC
Repurposing this bug for the general pattern.  Will close 49974 as a dupe of this.
Comment 3 ssastry 2013-08-12 20:17:56 UTC
*** Bug 49974 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2013-08-12 20:20:20 UTC
Change 78907 had a related patch set uploaded by Subramanya Sastry:
P-handler specific fix of bug 52762

https://gerrit.wikimedia.org/r/78907
Comment 5 Gerrit Notification Bot 2013-08-13 19:41:32 UTC
Change 78907 merged by jenkins-bot:
P-handler specific fix of bug 52762

https://gerrit.wikimedia.org/r/78907
Comment 6 Gerrit Notification Bot 2013-08-26 16:53:47 UTC
Change 81014 had a related patch set uploaded by Subramanya Sastry:
(Bug 52762) Lines with 1+ comments and WS are transparent to handlers

https://gerrit.wikimedia.org/r/81014
Comment 7 Gerrit Notification Bot 2013-08-26 23:08:26 UTC
Change 81014 merged by jenkins-bot:
(Bug 52762) Lines with 1+ comments and WS are transparent to handlers

https://gerrit.wikimedia.org/r/81014

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links