Last modified: 2013-08-13 10:11:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54773, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52773 - Special:ResetTokens tokens list uses an HTML table rather than an unordered list
Special:ResetTokens tokens list uses an HTML table rather than an unordered list
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.22.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-12 21:57 UTC by MZMcBride
Modified: 2013-08-13 10:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-08-12 21:57:24 UTC
https://en.wikipedia.org/wiki/Special:ResetTokens

Current HTML:

---
<table><tbody>
<tr class="mw-htmlform-field-HTMLMultiSelectField"><td class="mw-label"><label>Tokens:</label></td><td class="mw-input"> <div class="mw-htmlform-flatlist-item"><input name="wptokens[]" type="checkbox" value="watchlisttoken" id="mw-input-wptokens-watchlisttoken" />&#160;<label for="mw-input-wptokens-watchlisttoken">Watchlist web feed token (current value: z0050e875795edd56864bdfef28a0000ec00046g)</label></div>
</td></tr>
</tbody></table>
---

I think this is strange markup to use, given that this is a pretty standard list. The visual output looks something like this:

Tokens:	[ ] Watchlist web feed token (current value: z0050e875795edd56864bdfef28a0000ec00046g)

I don't see any reason to use an HTML table here; using an unordered list seems much more semantic and sensible.
Comment 1 Bartosz Dziewoński 2013-08-12 22:08:38 UTC
That's what HTMLMultiSelectField does. The same markup is used all over the place, e.g. on [[Special:Preferences#mw-prefsection-gadgets]], but I guess looks a little sillier here since this is a form with only one field that only has one option.

Also, you've just revealed your watchlist token (unless you doctored that value), which the Preferences page specifically advises against. Good job! :P
Comment 2 MZMcBride 2013-08-12 23:33:18 UTC
(In reply to comment #1)
> That's what HTMLMultiSelectField does. The same markup is used all over the
> place, e.g. on [[Special:Preferences#mw-prefsection-gadgets]], but I guess
> looks a little sillier here since this is a form with only one field that
> only has one option.

Hrmph. Perhaps this should be a more generic bug, then?

> Also, you've just revealed your watchlist token (unless you doctored that
> value), which the Preferences page specifically advises against. Good job! :P

I'm not sure many hashes contain the letter Z. ;-)  It's not my real token.
Comment 3 Bartosz Dziewoński 2013-08-12 23:49:55 UTC
(In reply to comment #2)
> Hrmph. Perhaps this should be a more generic bug, then?

It would appear so.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links