Last modified: 2013-08-20 20:17:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54824, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52824 - Preserve positional template parameters even if a nested template contains a '='
Preserve positional template parameters even if a nested template contains a '='
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-13 23:49 UTC by Gabriel Wicke
Modified: 2013-08-20 20:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-08-13 23:49:12 UTC 
Derived from bug 51961, comment 1: Positional parameters with an '=' in them are converted to named parameters, even if the '=' is safely embedded inside a nested transclusion.

Minimal test case:

{{echo|{{echo|1=bar}}}}

To fix this, we should probably tokenize the value with appropriate flags and look at the remaining string content instead of the entire string.
Comment 1 Gerrit Notification Bot 2013-08-19 18:20:03 UTC 
Change 79836 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 52824) Improved handling of '=' char in tpl-param values

https://gerrit.wikimedia.org/r/79836
Comment 3 Gabriel Wicke 2013-08-19 18:48:14 UTC 
This is normally a syntactic diff only, but still annoying:
https://en.wikipedia.org/w/index.php?title=Hartsfield%E2%80%93Jackson_Atlanta_International_Airport&diff=565342506&oldid=564597913
Comment 4 Gerrit Notification Bot 2013-08-19 22:36:49 UTC 
Change 79836 merged by jenkins-bot:
(Bug 52824) Improved handling of '=' char in tpl-param values

https://gerrit.wikimedia.org/r/79836
Comment 5 ssastry 2013-08-20 20:17:58 UTC 
Now deployed to production.  Verified fixed on an old id of the airport pages.  Also verified the fix on https://fr.wikipedia.org/wiki/Robert_Soucy?veaction=edit as per bug 51961, comment 1.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links