Last modified: 2014-02-07 21:34:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54848, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52848 - VisualEditor: FlaggedRevs inserts its tabs in the midst of the edit and edit source tabs
VisualEditor: FlaggedRevs inserts its tabs in the midst of the edit and edit ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-02-13
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-14 14:35 UTC by Oliver Keyes
Modified: 2014-02-07 21:34 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (21.10 KB, image/png)
2013-08-14 14:35 UTC, Oliver Keyes 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Oliver Keyes 2013-08-14 14:35:16 UTC 
Created attachment 13098 [details]
Screenshot

On wikis with FlaggedRevs, the interface historically displays buttons in the order [edit][pending changes]. This seems logical.

Under the VE (screenshot attached) it goes [edit][pending changes][edit source]. This doesn't ;p. Restoring the previous setup (so that it would show as [edit][edit source][pending changes]) would be good.
Comment 1 Alex Monk 2014-02-02 16:24:48 UTC 
For me it shows [pending changes][edit] without VE (and the comments indicate this is the intended behaviur), so I think with VE should be [pending changes][edit][edit source].
Comment 2 Gerrit Notification Bot 2014-02-02 16:27:34 UTC 
Change 110862 had a related patch set uploaded by Alex Monk:
Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source'

https://gerrit.wikimedia.org/r/110862
Comment 3 Gerrit Notification Bot 2014-02-07 21:33:47 UTC 
Change 110862 merged by Catrope:
Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source'

https://gerrit.wikimedia.org/r/110862
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links