Last modified: 2014-02-12 23:52:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54858, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52858 - Formatter: Subsequent H1s swallowed by previous h2.
Formatter: Subsequent H1s swallowed by previous h2.
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-14 18:50 UTC by Jon
Modified: 2014-02-12 23:52 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2013-08-14 18:50:14 UTC
=1=
==1.1==
==1.2==
=2=
==2.1==
==2.2==


= h1 =
hello
Comment 1 Jon 2013-08-14 18:53:06 UTC
Create a page with the above wikitext.

the heading 'h1' is swallowed by the section 2.2.

What should probably happen is that the h1 should terminate the section.

I'd rather we didn't make our existing regular expression more complicated and instead did something more clever with the ParserOutput so that it returns an array of sections rather than bodytext (see bug 48551)
Comment 2 Jon 2013-08-15 19:27:58 UTC
I guess the best thing would be for pages which contain h1s is to make the h1s rather than the h2 collapsible otherwise the full article cannot be edited.

This would require a big rewrite of the formatter code though and using parser output instead of a big regex..
Comment 3 Jon 2013-09-24 22:38:24 UTC
I5e8d723d061f7003599b2a7f639bbe1301ba92e0 took care of this - they now collapse on h1s when present.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links