Last modified: 2013-09-26 16:03:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54860, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52860 - incorrect results for 'nobel prize' search
incorrect results for 'nobel prize' search
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Elasticsearch0.90.4
: browser-test-bug, upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-14 18:59 UTC by Chris McMahon
Modified: 2013-09-26 16:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
seemingly incorrect search result suggestions (107.89 KB, image/png)
2013-08-14 18:59 UTC, Chris McMahon
Details

Description Chris McMahon 2013-08-14 18:59:11 UTC
Created attachment 13099 [details]
seemingly incorrect search result suggestions

See screen shot

"Did you mean: noble prize" seems incorrect, there shouldn't be a suggestion for a misspelling and page that does not exist. 

Link to correct page does appear with different capitalization as "Nobel Prize" not "Nobel prize".  


Shown by 

$ bundle exec cucumber features/full_text.feature:88



    Examples: 
      | term            | suggestion      |
      | popular culatur | popular culture |
      | noble prize     | nobel prize     |
      | nobel prize     | none            |
      expected #<Watir::Anchor:0x..fafcfd7c75dcc9b1c located=true selector={:index=>0, :tag_name=>"a"}> not to exist (RSpec::Expectations::ExpectationNotMetError)
      ./features/step_definitions/search_steps.rb:134:in `/^(.*) is suggested$/'
      features/full_text.feature:88:in `Then <suggestion> is suggested'
Comment 1 Nik Everett 2013-08-21 15:34:46 UTC
I _think_ this is caused by https://github.com/elasticsearch/elasticsearch/issues/3547
Comment 2 Nik Everett 2013-08-27 18:41:59 UTC
I've seen a few more occurrences of this and now I'm sure this is caused by the elasticsearch bug.  I'm disabling this test until that bug is fixed....
Comment 3 Gerrit Notification Bot 2013-09-18 00:18:29 UTC
Change 84684 had a related patch set uploaded by Manybubbles:
Turn on phrase suggestion test.

https://gerrit.wikimedia.org/r/84684
Comment 4 Gerrit Notification Bot 2013-09-18 16:55:30 UTC
Change 84684 merged by jenkins-bot:
Turn on phrase suggestion test.

https://gerrit.wikimedia.org/r/84684
Comment 5 Nik Everett 2013-09-18 17:46:01 UTC
Merged.
Comment 6 Nik Everett 2013-09-26 16:03:22 UTC
In production and looking good.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links