Last modified: 2013-09-26 16:03:22 UTC
Created attachment 13099 [details] seemingly incorrect search result suggestions See screen shot "Did you mean: noble prize" seems incorrect, there shouldn't be a suggestion for a misspelling and page that does not exist. Link to correct page does appear with different capitalization as "Nobel Prize" not "Nobel prize". Shown by $ bundle exec cucumber features/full_text.feature:88 Examples: | term | suggestion | | popular culatur | popular culture | | noble prize | nobel prize | | nobel prize | none | expected #<Watir::Anchor:0x..fafcfd7c75dcc9b1c located=true selector={:index=>0, :tag_name=>"a"}> not to exist (RSpec::Expectations::ExpectationNotMetError) ./features/step_definitions/search_steps.rb:134:in `/^(.*) is suggested$/' features/full_text.feature:88:in `Then <suggestion> is suggested'
I _think_ this is caused by https://github.com/elasticsearch/elasticsearch/issues/3547
I've seen a few more occurrences of this and now I'm sure this is caused by the elasticsearch bug. I'm disabling this test until that bug is fixed....
Change 84684 had a related patch set uploaded by Manybubbles: Turn on phrase suggestion test. https://gerrit.wikimedia.org/r/84684
Change 84684 merged by jenkins-bot: Turn on phrase suggestion test. https://gerrit.wikimedia.org/r/84684
Merged.
In production and looking good.