Last modified: 2013-09-26 15:06:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54886, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52886 - Prefix search returns subpage ahead of main page


Summary:	Prefix search returns subpage ahead of main page

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CirrusSearch (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nik Everett

URL:
Whiteboard:
Keywords:	browser-test-bug

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-15 17:03 UTC by Chris McMahon
Modified:	2013-09-26 15:06 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
unexpected suggestion order (41.40 KB, image/png) 2013-08-15 17:03 UTC, Chris McMahon	Details
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2013-08-15 17:03:25 UTC

Created attachment 13102 [details]
unexpected suggestion order

seen on http://commons.wikimedia.beta.wmflabs.org/

In search box type "ma"

First result should be "Main Page" but is "Main Page/motd"

See screen shot for full results.

Comment 1 Nik Everett 2013-08-15 19:39:41 UTC

After some digging it looks like prefix suggestions are being returned in the order of their database id rather than the page-rank like algorithm used in lsearchd.  This might take me some time to fix....

Comment 2 Nik Everett 2013-08-16 00:47:35 UTC

I lied - it doesn't return them in order of their database id.  That is a tiebreaker in case of ties, but we don't have a tie in this case.  It is more confusing than that.  I'm working on a solution though.

Comment 3 Nik Everett 2013-08-19 14:26:30 UTC

OK!  I've got a solution working here:
https://gerrit.wikimedia.org/r/#/c/79789/

and tests here:
https://gerrit.wikimedia.org/r/#/c/79788/

Now the page with the most links to it will be returned by a prefix query, subpage or not.   This is pretty much how the current search implementation works.

Comment 4 Gerrit Notification Bot 2013-08-19 18:07:25 UTC

Change 79789 had a related patch set uploaded by Demon:
Return most relevent prefix search results.

https://gerrit.wikimedia.org/r/79789

Comment 5 Gerrit Notification Bot 2013-08-19 18:08:23 UTC

Change 79789 merged by jenkins-bot:
Return most relevent prefix search results.

https://gerrit.wikimedia.org/r/79789

Comment 6 Nik Everett 2013-09-26 15:06:16 UTC

Live and working.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links