Last modified: 2014-05-05 06:53:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54887, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52887 - undelete.php should display an error when it fails
undelete.php should display an error when it fails
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-15 17:24 UTC by Dan Barrett
Modified: 2014-05-05 06:53 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Barrett 2013-08-15 17:24:14 UTC 
If you run the undelete.php script for a File: article, it prints success but actually doesn't undelete the article.

$ php undelete.php "File:Example.jpg"
Undeleting File:Example.jpg...done

However, File:Example.jpg still does not exist.

Undeleting using the GUI ("Undelete" menu item) works fine.
Comment 1 Dan Barrett 2013-08-15 17:25:32 UTC 
Even using the Wikisysop user doesn't undelete the page:

$ php undelete.php --user Wikisysop "File:Example.jpg"
Comment 2 Dan Barrett 2013-08-15 17:36:08 UTC 
I figured out the problem. "php" should be "sudo php": the script didn't have permission to restore the file.

So this bug is really that undelete.php has poor error messaging. I will change the title.
Comment 3 Dan Barrett 2013-08-15 17:37:33 UTC 
undelete.php should display an error message when:

- It fails to restore a real article (that has been previously deleted), say, due to permission problems
- It is instructed to restore an article that does not exist
Comment 4 Gerrit Notification Bot 2014-05-05 06:53:10 UTC 
Change 131431 had a related patch set uploaded by Withoutaname:
Introduce error handling for undelete.php

https://gerrit.wikimedia.org/r/131431
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links