Last modified: 2013-10-28 21:18:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54938, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52938 - Tabs do not cause indent-pres, only spaces do
Tabs do not cause indent-pres, only spaces do
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-16 18:05 UTC by ssastry
Modified: 2013-10-28 21:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2013-08-16 18:05:56 UTC 
See https://gerrit.wikimedia.org/r/#/c/79341/

Parsoid currently treats tabs like spaces when it comes to indent-pres.
Comment 1 Gabriel Wicke 2013-08-16 18:37:18 UTC 
http://parsoid.wmflabs.org/pl/Wikipedia:Strona_g%C5%82%C3%B3wna does look somewhat preformatted. Too bad that this inconsistency is exploited. Would be tempting to fix it otherwise.
Comment 2 Bartosz Dziewoński 2013-08-16 18:44:22 UTC 
I doubt it's exploited widely, but it does sometimes make the code cleaner when using complicated markup, such as on that main page.

Removing the tabs there would be easy and I can do that; I remember being surprised that this worked when I wrote it.

We should get some stats, but I'd be surprised if it affects any other page on any wiki.
Comment 3 Gerrit Notification Bot 2013-10-28 19:42:20 UTC 
Change 92364 had a related patch set uploaded by GWicke:
Bug 52938: Don't trigger indent pre on tabs

https://gerrit.wikimedia.org/r/92364
Comment 4 Gerrit Notification Bot 2013-10-28 20:06:38 UTC 
Change 92364 merged by jenkins-bot:
Bug 52938: Only trigger indent pre on spaces

https://gerrit.wikimedia.org/r/92364
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links