Last modified: 2013-09-03 23:30:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54940, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52940 - Sanitizer strips extension about/typeof for some extension
Sanitizer strips extension about/typeof for some extension
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-16 18:08 UTC by ssastry
Modified: 2013-09-03 23:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2013-08-16 18:08:38 UTC 
The timeline extension generates a <map> tag which gets typeof and about attributes added to it by the ExtensionHandler.  But, the sanitizer strips these attibutes from the map tag since it is not whitelisted.

We need a fix to the sanitizer: either whitelisting of additional tags for approved extensions, or blanket whitelisting of extension-output-marked tags.
Comment 1 Gabriel Wicke 2013-08-16 18:22:12 UTC 
We should be able to blanket-whitelist mw: typeofs if we strip those from user content early in the token stream. This is covered by bug 48772.
Comment 2 Gerrit Notification Bot 2013-08-28 20:35:36 UTC 
Change 81569 had a related patch set uploaded by Subramanya Sastry:
(Bug 52940): Pass through parsoid-inserted attrs in sanitizer

https://gerrit.wikimedia.org/r/81569
Comment 3 Gerrit Notification Bot 2013-09-03 23:23:25 UTC 
Change 81569 merged by jenkins-bot:
(Bug 52940) Don't block parsoid-inserted attrs in sanitizer

https://gerrit.wikimedia.org/r/81569
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links