Last modified: 2014-02-10 20:08:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54982, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52982 - VisualEditor: Clicking "Review changes" collapses save dropdown, and disappears the thermometer
VisualEditor: Clicking "Review changes" collapses save dropdown, and disappea...
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-18 08:11 UTC by Adam Wight
Modified: 2014-02-10 20:08 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Adam Wight 2013-08-18 08:11:02 UTC
The thermometer is important, as it explains why a radically modified document would give me an empty "review changes" box.

Separate bugs: the thermometer never stops spinning, and my changes for review never appear--maybe Parsoid is gagging.  And, is that UI javascript running without a setTimeout?
Comment 1 MZMcBride 2013-08-18 08:28:27 UTC
How does a thermometer spin?
Comment 2 James Forrester 2013-08-19 23:07:23 UTC
Trying to parse this. Is this:

1. 'VisualEditor: Clicking "Review changes" mid-save causes the save dialog to disappear, which takes the save progress animation thermometer'

… or

2. 'VisualEditor: Clicking "Review changes" mid-save causes the save dialog to collapse but stay present, and also the save progress animation thermometer stays but stops animating'

… or something else?
Comment 3 Adam Wight 2013-08-19 23:50:17 UTC
Sorry.

* Edit a page, making changes
* Click "Save page".  Save dialog pops down, and thermometer is spinning.
* Click "Review changes" before the thermometer stops.
The save dialog collapses down to a single line, which contains only the "Review changes" button, a left arrow button, and an up button.  This is strange.  The thermometer is gone.  There is no explanation of why i am presented with this damaged dialog.

Apparently, with my broken VE, the loading/render/whatever the thermometer represents never finishes.  Which made it very easy to reproduce this other bug.
Comment 4 Alex Monk 2014-02-09 03:21:30 UTC
I don't see a thermometer. :|
Comment 5 James Forrester 2014-02-10 20:08:48 UTC
We can't reproduce this now, so closing as WORKSFORME.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links