Last modified: 2014-01-24 23:41:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54983, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52983 - Undo buffer can be fooled
Undo buffer can be fooled
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-18 08:15 UTC by Adam Wight
Modified: 2014-01-24 23:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Adam Wight 2013-08-18 08:15:20 UTC 
Something terrible happened behind the scenes in VE, see bug 52982.  When I tried to undo, the glitch-induced changes were not reverted, and it's possible that the undo algorithm was responsible for further damage to the document.

I would review how operations are being stored in the stack.  Are there content checksums, or other error-checking measures such as absolute diff position?  It might be feasible to store entire copies of the page content as savepoints.
Comment 1 James Forrester 2014-01-24 23:41:18 UTC 
This is effectively "a fatal JS error means bad things for lots of the interface". Sadly something to avoid happening so this doesn't occur…
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links