Last modified: 2014-04-28 17:50:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55009, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53009 - VisualEditor: Globally-blocked logged-out users are not blocked from using VE (just from saving); should instead show the relevant global block message
VisualEditor: Globally-blocked logged-out users are not blocked from using VE...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-04-24
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-18 21:28 UTC by Oliver Keyes
Modified: 2014-04-28 17:50 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (133.71 KB, image/jpeg)
2013-08-18 21:28 UTC, Oliver Keyes
Details

Description Oliver Keyes 2013-08-18 21:28:58 UTC
Created attachment 13122 [details]
Screenshot

Blocked IP addresses can see the VisualEditor, use it, and are presented with the error in the screenshot when saving.

Reporting distinctly from bug 52004 because the error message and use case are both somewhat different.
Comment 1 Gerrit Notification Bot 2014-04-22 00:25:10 UTC
Change 127840 had a related patch set uploaded by Alex Monk:
Show notice if user is globally blocked

https://gerrit.wikimedia.org/r/127840
Comment 2 Alex Monk 2014-04-22 00:25:43 UTC
That error message that you do get on saving is also a bug of it's own, patched in Gerrit change #127835
Comment 3 Gerrit Notification Bot 2014-04-22 23:02:29 UTC
Change 127840 merged by jenkins-bot:
Show notice if user is globally blocked

https://gerrit.wikimedia.org/r/127840
Comment 4 Alex Monk 2014-04-22 23:50:36 UTC
As with the normal local block bug, I'm going to mark this as fixed. We don't block the user from using VE, but there is now a notice warning them when they open VE.

It would be difficult to get all the useful info into some smaller alert() message or similar. Though after thinking about it a bit more we could perhaps use a small VE dialog or something, I am open to suggestions of course - but perhaps that would be better to put in a more general "not able to edit page due to protection/block/etc. dialog error" as this patch simply brings global blocks into line with normal blocks, protection etc.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links