Last modified: 2014-10-09 23:48:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55109, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53109 - Use data.* instead of manual JSON attribute loading / saving throughout the DOM postprocessor


Summary:	Use data.* instead of manual JSON attribute loading / saving throughout the D...

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	DOM (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low enhancement
Target Milestone:	---
Assigned To:	Arlo Breault

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-20 19:11 UTC by Gabriel Wicke
Modified:	2014-10-09 23:48 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-08-20 19:11:25 UTC

We have moved data-parsoid to data.parsoid on the DOM and save that data at the end of DOM postprocessing. Other attributes like data-mw are currently handled manually.

It would probably be both faster and more convenient to use data.* for those attributes as well. The necessary support for loading and saving them is mostly implemented in loadDataAttrib (missing: loadDataAttribs) and saveDataAttribs. With the exception of data-parsoid, we should only load data attributes that are actually defined by default.

Comment 1 Gerrit Notification Bot 2014-09-09 04:46:41 UTC

Change 159254 had a related patch set uploaded by Arlolra:
Move data-mw away from manual JSON attr loading

https://gerrit.wikimedia.org/r/159254

Comment 2 Gerrit Notification Bot 2014-09-26 17:33:46 UTC

Change 159254 had a related patch set uploaded by Arlolra:
(Bug 53109) Move data-mw away from manual JSON attr loading

https://gerrit.wikimedia.org/r/159254

Comment 3 Gerrit Notification Bot 2014-09-28 00:13:31 UTC

Change 159254 merged by jenkins-bot:
(Bug 53109) Move data-mw away from manual json attr loading

https://gerrit.wikimedia.org/r/159254

Comment 4 Arlo Breault 2014-10-09 22:56:44 UTC

Aren't there other data-* properties left to do?

Comment 5 Arlo Breault 2014-10-09 23:48:09 UTC

I guess I was thinking about

data-parsoid-diff, data-parsoid-serialize

but I those are just serialization things.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links