Last modified: 2013-08-25 17:10:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55168, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53168 - empty diffs set class="diff-multi"
empty diffs set class="diff-multi"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Umherirrender
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-21 19:24 UTC by Fomafix
Modified: 2013-08-25 17:10 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
$notice instead of $multi (684 bytes, patch)
2013-08-21 19:24 UTC, Fomafix
Details

Description Fomafix 2013-08-21 19:24:50 UTC
Created attachment 13144 [details]
$notice instead of $multi

https://gerrit.wikimedia.org/r/#/c/73014/ breaks JavaScripts that use class='diff-multi' to identify multi diffs because the class get set when there is not multi diff but a empty diff.

Suggested solution: Use a separate table row for diff-empty.
The attached patch uses $notice instead of $multi. A new table row would be an other way.
Comment 1 Andre Klapper 2013-08-21 21:23:33 UTC
Hi! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it quickly.
Comment 2 Gerrit Notification Bot 2013-08-22 17:21:03 UTC
Change 80406 had a related patch set uploaded by Umherirrender:
Add class around diff-empty and add it as notice

https://gerrit.wikimedia.org/r/80406
Comment 3 Gerrit Notification Bot 2013-08-25 17:10:19 UTC
Change 80406 merged by jenkins-bot:
Add class around diff-empty and add it as notice

https://gerrit.wikimedia.org/r/80406

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links