Last modified: 2013-09-10 22:21:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55176, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53176 - Notifications: Not getting notified for reverts if Preview or Show Changes is used
Notifications: Not getting notified for reverts if Preview or Show Changes is...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-21 21:09 UTC by Quiddity
Modified: 2013-09-10 22:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2013-08-21 21:09:02 UTC
If a user clicks Preview or Show Changes before hitting Save, then it won't send a notification.

Anomie explains why, in the penultimate comment here:
https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications/Archive_4#Edit_reverts
"Looking at the code, it appears that Echo detects an "undo" by looking for the field wpUndidRevision in the submitted form data. This field is present in the form created when using the 'undo' link, but it isn't maintained if you use the Preview or Show changes buttons on the edit form. So "undo → Save page" would be notified as an undo, while "undo → Preview → Save page" or "undo → Show changes → Save page" wouldn't be. Anomie⚔ 10:43, 18 July 2013 (UTC)"

a second example is mentioned here:
https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#No_notification
Comment 1 Gerrit Notification Bot 2013-08-23 23:00:09 UTC
Change 80680 had a related patch set uploaded by Bsitu:
wpUndidRevision should be passed along during 'preview' and 'diff'

https://gerrit.wikimedia.org/r/80680
Comment 2 Gerrit Notification Bot 2013-08-26 15:32:45 UTC
Change 80680 merged by jenkins-bot:
wpUndidRevision should be passed along during 'preview' and 'diff'

https://gerrit.wikimedia.org/r/80680
Comment 3 Gerrit Notification Bot 2013-08-27 17:40:35 UTC
Change 81264 had a related patch set uploaded by Bsitu:
wpUndidRevision should be passed along during 'preview' and 'diff'

https://gerrit.wikimedia.org/r/81264
Comment 4 Gerrit Notification Bot 2013-08-27 17:42:51 UTC
Change 81265 had a related patch set uploaded by Bsitu:
wpUndidRevision should be passed along during 'preview' and 'diff'

https://gerrit.wikimedia.org/r/81265
Comment 5 Gerrit Notification Bot 2013-08-27 17:57:35 UTC
Change 81264 merged by jenkins-bot:
wpUndidRevision should be passed along during 'preview' and 'diff'

https://gerrit.wikimedia.org/r/81264
Comment 6 Gerrit Notification Bot 2013-08-27 18:47:43 UTC
Change 81265 merged by jenkins-bot:
wpUndidRevision should be passed along during 'preview' and 'diff'

https://gerrit.wikimedia.org/r/81265

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links