Last modified: 2014-02-12 23:45:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55179, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53179 - Clicking "edit this page" doesn't work in mobile site
Clicking "edit this page" doesn't work in mobile site
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-21 22:11 UTC by Ryan Kaldari
Modified: 2014-02-12 23:45 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Roary the page creation guy (77.60 KB, image/png)
2013-09-11 20:03 UTC, Jon
Details

Description Ryan Kaldari 2013-08-21 22:11:58 UTC
Steps to reproduce:
1. In your local instance, go to the article "NoExisto"
2. Click "edit this page" in the message "There is currently no text in this page. You can search for this page title in other pages, search the related logs, or edit this page."

or

1. In your local instance, go to index.php?title=NoExisto&action=edit

What happens:
The user goes to index.php?title=NoExisto&action=edit which redirects back to the article page.

What should happen:
The user goes to the editing interface (or gets the log-in CTA if they need to log in)
Comment 1 Jon 2013-08-22 00:24:14 UTC
When action=edit is present in the url it simply doesn't load the editor on mobile. We should hijack these links in JavaScript if they are easy to identify or we should assign them a hash.

Unfortunately this link will not work for editors on older phones. Maybe hiding it for the time being would be a good idea (similar to how we scrub red links)?
Comment 2 Jon 2013-08-23 18:21:48 UTC
The existing behavior of refreshing is confusing. i think the best thing might be to add a blue button saying edit this page that when clicked loads the editor would be a good workaround for the time being.
Comment 3 Ryan Kaldari 2013-08-23 18:30:38 UTC
Hiding the links would be tricky as they aren't easy to identify. In this case it just appears in the content of the page without any particular class or ID. I agree it would probably be best to not refresh, and instead present them with some interface to launch the editor. Long term, we should think about how to load the mobile editing interface via action=edit without having an intermediate step if possible.
Comment 4 Jon 2013-08-23 21:14:40 UTC
Added design tag so we can move forward on this.
Comment 5 Jon 2013-09-11 17:21:41 UTC
So... we can override the default page for new pages (in alpha):
https://gerrit.wikimedia.org/r/#/c/83772/

This just leaves links that editors leave. Should we worry about those?
Comment 6 Jared Zimmerman (WMF) 2013-09-11 18:17:24 UTC
I'm going to defer to Vibha on this, but my high level summary below:


Ideally we have a special page on mobile with some level of guidance for creating a page from scratch, the full desktop page doesn't cut it.

Seems like the page is/should be split between "Is this what you meant" helping user who mistyped, didn't use the right capitalization, searched the wrong project and user who really did want to start a new article. the ratio of these two user cases is probably 80/20 [citation needed]

We should consider a different icon for create new article rather than the normal "edit"

Why can't users start the article creation process with an image?
Comment 7 Jon 2013-09-11 20:03:17 UTC
Created attachment 13272 [details]
Roary the page creation guy

This is rather a niche case - since an editor can link anywhere, editors tend to put edit links inside pages. On mobile this doesn't do anything as all editing is JavaScript based. That said, then clicking on the edit button should be pretty straight forward

First version is merged into alpha (see attachment)
Comment 8 Gerrit Notification Bot 2013-09-19 00:29:29 UTC
Change 84913 had a related patch set uploaded by JGonera:
Redirect &action=edit&section=X to mobile editor

https://gerrit.wikimedia.org/r/84913
Comment 9 Gerrit Notification Bot 2013-09-23 18:08:18 UTC
Change 84913 merged by jenkins-bot:
Redirect &action=edit&section=X to mobile editor

https://gerrit.wikimedia.org/r/84913

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links