Last modified: 2013-09-05 06:18:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55191, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 53191 - flow.sql hardcodes wiki name in definition INSERT statements


Summary:	flow.sql hardcodes wiki name in definition INSERT statements

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Flow (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://www.mediawiki.org/wiki/Extens...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-22 00:44 UTC by spage
Modified:	2013-09-05 06:18 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2013-08-22 00:44:38 UTC

The update script flow.sql has
    INSERT INTO flow_definition
	( definition_id, definition_wiki, definition_name, definition_type, definition_options )
	VALUES
	( unhex('4ffebfa36a3155f2416080027a082220'), 'wiki', ...

The hardcoded 'wiki' should be wfWikiID().

I think doing the insert in a script run by $updater->addPostDatabaseUpdateMaintenance( '' ) might work; AFTv5 did this.

Extension:Flow#Installing documents the issue.

Comment 1 spage 2013-09-05 06:18:15 UTC

Gerrit change #81253 fixed this!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links