Last modified: 2014-02-12 19:00:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55219, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53219 - VisualEditor: [Regression] Link inspector prevents insertion of section links
VisualEditor: [Regression] Link inspector prevents insertion of section links
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest critical
: VE-deploy-2013-08-29
Assigned To: Ed Sanders
:
Depends on:
Blocks: 50881
  Show dependency treegraph
 
Reported: 2013-08-22 16:25 UTC by Chris McKenna
Modified: 2014-02-12 19:00 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
VE link insertion dialog when attempting to add a section link (16.14 KB, image/png)
2013-08-22 16:25 UTC, Chris McKenna
Details

Description Chris McKenna 2013-08-22 16:25:49 UTC
Created attachment 13150 [details]
VE link insertion dialog when attempting to add a section link

Since the latest update it is impossible to create links to specific sections of a page in VisualEditor: As soon as you enter the # character the link insertion dialog gives an "Invalid title" error. See screenshot attached and bug 50881 comment 11.

I've reported this separately to bug 50881 as that is an enhancement to give proper handling of section links, but this is a regression that blocks all use of links to sections.
Comment 1 Quim Gil 2013-08-22 16:56:50 UTC
Ah, good that someone already reported. Confirmed in mediawiki.org.
Comment 2 Gerrit Notification Bot 2013-08-22 18:27:09 UTC
Change 80417 had a related patch set uploaded by Esanders:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80417
Comment 3 Gerrit Notification Bot 2013-08-22 21:21:57 UTC
Change 80417 merged by jenkins-bot:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80417
Comment 4 James Forrester 2013-08-22 21:23:44 UTC
This is now fixed in master; we'll cherry-pick it and push live this afternoon. Sorry for the problem.
Comment 5 Gerrit Notification Bot 2013-08-22 22:38:46 UTC
Change 80505 had a related patch set uploaded by Jforrester:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80505
Comment 6 Gerrit Notification Bot 2013-08-22 22:40:15 UTC
Change 80507 had a related patch set uploaded by Jforrester:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80507
Comment 7 Gerrit Notification Bot 2013-08-22 22:55:56 UTC
Change 80505 merged by Catrope:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80505
Comment 8 Gerrit Notification Bot 2013-08-22 22:56:00 UTC
Change 80507 merged by Catrope:
Modify regex to allow section links as valid titles

https://gerrit.wikimedia.org/r/80507
Comment 9 James Forrester 2013-08-22 23:17:51 UTC
… and now deployed.
Comment 10 Elitre 2014-02-11 16:45:33 UTC
Unless I'm missing something obvious, I can't make this work anymore on it.wp or Mediawiki. It will just ignore the #name_of_the_section if I add it to an existing wikilink and therefore, it will not recognize the link as edited and the Save button will stay greyed out.
Comment 11 James Forrester 2014-02-11 17:12:53 UTC
(In reply to comment #10)
> Unless I'm missing something obvious, I can't make this work anymore on it.wp
> or Mediawiki. It will just ignore the #name_of_the_section if I add it to an
> existing wikilink and therefore, it will not recognize the link as edited and
> the Save button will stay greyed out.

Split that issue into bug 61221.
Comment 12 Gerrit Notification Bot 2014-02-12 15:27:55 UTC
Change 112898 had a related patch set uploaded by Esanders:
Include fragments in normalizedTitle

https://gerrit.wikimedia.org/r/112898
Comment 13 Gerrit Notification Bot 2014-02-12 18:32:10 UTC
Change 112898 merged by jenkins-bot:
Include fragments in normalizedTitle

https://gerrit.wikimedia.org/r/112898

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links