Last modified: 2013-10-25 21:09:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55224, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53224 - VisualEditor: Undo/redo doesn't go through dm.Surface.change() code path
VisualEditor: Undo/redo doesn't go through dm.Surface.change() code path
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-10-31
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-22 17:14 UTC by Roan Kattouw
Modified: 2013-10-25 21:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-08-22 17:14:26 UTC 
dm.Surface.undo() and .redo() just call documentModel.rollback() / .commit() directly, without going through all the other stuff in .change() . Presumably this other stuff is useful, so we should figure out if bypassing it causes bugs.
Comment 1 C. Scott Ananian 2013-08-22 17:15:52 UTC 
In theory Surface.change() should also have a corresponding Surface.unchange() method (or a 'reversed' parameter).
Comment 2 Gerrit Notification Bot 2013-10-09 13:41:23 UTC 
Change 88728 had a related patch set uploaded by Catrope:
Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

https://gerrit.wikimedia.org/r/88728
Comment 3 Gerrit Notification Bot 2013-10-25 21:05:34 UTC 
Change 88728 merged by jenkins-bot:
Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

https://gerrit.wikimedia.org/r/88728
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links