Last modified: 2014-03-10 19:14:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55225, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53225 - VisualEditor: When reversing a transaction, create a new transaction rather than reusing the old one
VisualEditor: When reversing a transaction, create a new transaction rather t...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2013-10-10
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-22 17:27 UTC by Roan Kattouw
Modified: 2014-03-10 19:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-08-22 17:27:25 UTC
Rather than passing around boolean parameters called 'reversed' all over the place, we should use each transaction only once, and implement a function that creates a new transaction that's the reverse of an existing transaction.
Comment 1 C. Scott Ananian 2013-08-28 01:19:55 UTC
But note that the code currently uses the fact that the commit and rollback transaction are the same in order to update the 'applied' field.  So the rollback transaction should still contain a pointer to the original transaction, and when it is committed both should be marked with 'applied=false' (which indicates that we can skip over these entries in the completeHistory).
Comment 2 Roan Kattouw 2014-03-10 19:14:17 UTC
This was done ages ago in I3050c5430be4a12510f22e20853560b92acebb67

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links