Last modified: 2014-03-26 18:35:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55233, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53233 - Malformed attribute in table (="text-align:left" align=center) not hidden from view
Malformed attribute in table (="text-align:left" align=center) not hidden fro...
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
http://parsoid.wmflabs.org/_rt/es/Bilbao
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-22 19:58 UTC by Jan Eissfeldt
Modified: 2014-03-26 18:35 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 James Forrester 2013-08-22 22:07:34 UTC
The wikitext here is malformed:

  {|class="wikitable" ="text-align:left" align=center

… is becoming:

  ="text-align:left" align=center{|class="wikitable" ="text-align:left" align=center

on round-trip through Parsoid.


Of course, the wikitext should instead be the following:

  {| class="wikitable" style="text-align:left" align=center

… but VE/Parsoid should ideally not corrupt this. :-)
Comment 2 James Forrester 2013-08-22 22:12:31 UTC
(Moved to Parsoid because VE is claiming not to have dirtied the DOM.)
Comment 3 Gabriel Wicke 2013-08-27 20:16:37 UTC
This is still the case without selective serialization [1], but fixed in production [2] (although the save currently times out). Those broken attributes are still recognized as text and then fostered out, but this fostered content is now properly detected and handled by the selective serialization algorithm so that it does not normally produce dirty diffs.

While the original bug is fixed, I'm leaving this bug open as we should try harder to match invalid attributes on table start tags, so that those are not fostered out later.

[1]: http://parsoid.wmflabs.org/_rt/es/Bilbao?oldid=69046152
[2]: http://es.wikipedia.org/w/index.php?title=Usuario:GWicke/test1&veaction=edit
Comment 4 Gabriel Wicke 2013-12-03 23:37:45 UTC
Updated subject to reflect that this no longer corrupts, but does not render perfectly either.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links