Last modified: 2013-08-30 08:10:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55243, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53243 - Language links not correctly marked as "mw:WikiLink/Language" by Parsoid
Language links not correctly marked as "mw:WikiLink/Language" by Parsoid
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-22 21:48 UTC by Kelson [Emmanuel Engelhart]
Modified: 2013-08-30 08:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kelson [Emmanuel Engelhart] 2013-08-22 21:48:22 UTC
(Bug coming from #51430 comment)

As far as I can see, these links are not marked "mw:WikiLink/Language" but
simply "mw:WikiLink". So, it's not possible to make any difference between them and "normal" wikilinks.

See a the end of this page for example:
http://parsoid.wmflabs.org/ko/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8
Comment 1 Gabriel Wicke 2013-08-27 21:47:52 UTC
The reason might be that those are marked as "local" in the interwiki info returned from the API. That means that there is a redirect configured from http://en.wikipedia.org/wiki/ko: to http://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8. 

We should still mark them as language links as that is the way they are interpreted by the PHP parser. Pointing the href to the absolute URL ending in /wiki/ should also be fine as that redirects to the wiki's main page just as the local redirect does.
Comment 2 Gerrit Notification Bot 2013-08-27 22:11:40 UTC
Change 81413 had a related patch set uploaded by GWicke:
Bug 53243: Accept prefix-only interwiki / language links

https://gerrit.wikimedia.org/r/81413
Comment 3 Gabriel Wicke 2013-08-27 22:14:09 UTC
See bug 53432 for a related serializer bug uncovered by the tests added in the patch above.
Comment 4 Gerrit Notification Bot 2013-08-28 23:08:37 UTC
Change 81413 merged by jenkins-bot:
Bug 53243: Accept prefix-only interwiki / language links

https://gerrit.wikimedia.org/r/81413
Comment 5 Gabriel Wicke 2013-08-29 23:54:31 UTC
Now deployed in production.

Note that we are planning to rename some of these typeofs. mw:WikiLink/Language will likely become mw:PageProp/Language. See https://bugzilla.wikimedia.org/show_bug.cgi?id=53432 for the details, and let us know if you see issues for Kiwix.
Comment 6 Kelson [Emmanuel Engelhart] 2013-08-30 08:10:29 UTC
THX. As long as I can identify the language links, this is good to me; whatever how this is labelled.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links