Last modified: 2013-10-08 13:57:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55255, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53255 - [INTERLANG] Previewed language is not discarded when exiting the ULS Language panel with a close button
[INTERLANG] Previewed language is not discarded when exiting the ULS Language...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Kartik Mistry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-23 14:40 UTC by Runa Bhattacharjee
Modified: 2013-10-08 13:57 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Runa Bhattacharjee 2013-08-23 14:40:18 UTC
Previewed user interface messages of a language clicked/selected in the ULS Language Settings panel, but not applied, does not go away when the panel is closed using the X/Close button.

Steps to Reproduce:

[User needs to be logged in]
1. Open 'Display Settings' from Language panel by clicking on the cog icon near the Interlanguage links
2. Click on a language button that is not the current selection or select another language using the ULS language search dialog displayed from the ... button
3. Check that User Interface messages within the panel are displayed using this newly selected language
4. Do not apply the settings. Close the panel using the ‘X’/close button at the top right corner of the panel.
5. Re-open the panel using the cog icon

Actual Results:

The preview is still active in the language that was selected (but not applied) in step 2.

Expected Results:

The preview should have been discarded.
Comment 1 Niklas Laxström 2013-08-24 08:13:12 UTC
Quite similar to bug 53202 - maybe they have the same cause.
Comment 2 Gerrit Notification Bot 2013-08-26 10:37:09 UTC
Change 80975 had a related patch set uploaded by Santhosh:
Make the behavior of close button same as cancel button

https://gerrit.wikimedia.org/r/80975
Comment 3 Gerrit Notification Bot 2013-08-26 14:56:33 UTC
Change 80975 merged by jenkins-bot:
Make the behavior of close button same as cancel button

https://gerrit.wikimedia.org/r/80975
Comment 4 Amir E. Aharoni 2013-09-17 17:41:28 UTC
Fixed, but needs a test.
Comment 6 Kartik Mistry 2013-10-08 13:57:59 UTC
Fixed. Tests are added at: https://gerrit.wikimedia.org/r/#/c/85874/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links