Last modified: 2013-08-28 19:59:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55404, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53404 - Gerrit should disallow upload of merge commits.
Gerrit should disallow upload of merge commits.
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-27 14:53 UTC by C. Scott Ananian
Modified: 2013-08-28 19:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description C. Scott Ananian 2013-08-27 14:53:00 UTC
When people accidentally upload merge commits, things can get very confusing.

See https://gerrit.wikimedia.org/r/80483

Gerrit gets confused because it can't rebase the patch, because the merged commit is already applied, etc.  Jenkins also seems to fail.  So the result is a patch that can never be merged.

We should just make 'git review' fail with a sensible error if the user tries to upload a merge commit.
Comment 1 christian 2013-08-27 15:46:56 UTC
I would not want to turn that capability off globally on our
gerrit. Some people want to be able to upload merge commits.

If merge commits cause more problems for your repos than they solve,
you can disable pushing of merge commits on a per project basis in the
Project's Access Tab within gerrit. Just revoke the “Push Merge
Commit” capability; either for the whole project or just on some
relevant refs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links