Last modified: 2013-10-09 13:44:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55426, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53426 - CirrusSearch includes the text of audio tags
CirrusSearch includes the text of audio tags
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nik Everett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-27 21:35 UTC by Nik Everett
Modified: 2013-10-09 13:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2013-08-27 21:35:15 UTC
Searching for "JavaScript disabled" finds pages with audio.

http://en.wikipedia.beta.wmflabs.org/w/index.php?search=%22JavaScript+disabled%22&title=Special%3ASearch&fulltext=1
Comment 1 Nik Everett 2013-08-29 00:57:46 UTC
Patch to review:  https://gerrit.wikimedia.org/r/#/c/81607/
Comment 2 Nik Everett 2013-08-29 01:06:38 UTC
Test patch to review: https://gerrit.wikimedia.org/r/#/c/81609/
Comment 3 Nik Everett 2013-09-03 21:19:46 UTC
So the reason this is languishing is that the patch uses an github dependency to parse the page into dom and them xpath to remove it.  That is cool and all but we're not super happy having another dependency and it is slow.  We don't like slow.

BTW, libxml and therefore built-in php DOMDocument don't support html5.
Comment 4 Nik Everett 2013-09-13 06:08:28 UTC
We've abandoned that particular patch and will be rewriting it using some functionality being merged into core soon.  For now I'm marking this On_Hold but I plan to get to it as soon as our piece is merged into core.
Comment 5 Gerrit Notification Bot 2013-09-19 23:47:45 UTC
Change 85135 had a related patch set uploaded by Chad:
Overhaul wikitext formatting

https://gerrit.wikimedia.org/r/85135
Comment 6 Nik Everett 2013-09-23 17:08:32 UTC
Looks like the core change required for this (https://gerrit.wikimedia.org/r/#/c/84342/) just landed.  I'd like to wait until it is in production before we merge this patch just so we can still deploy from master.
Comment 7 Gerrit Notification Bot 2013-09-24 02:31:48 UTC
Change 85135 merged by jenkins-bot:
Overhaul wikitext formatting

https://gerrit.wikimedia.org/r/85135
Comment 8 Nik Everett 2013-10-09 13:44:13 UTC
Verified on cawiki.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links