Last modified: 2013-09-16 14:55:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55429, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53429 - Update DSR computation to ignore fostered content
Update DSR computation to ignore fostered content
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-27 21:42 UTC by ssastry
Modified: 2013-09-16 14:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-08-27 21:42:31 UTC
In bug 50502 comment 7, Guillaume reported:

-----
In this edit, a table was duplicated (but it wasn't in a template):
https://fr.wikipedia.org/w/index.php?&diff=96159772
-----

I was able to replicate this in Chrome.  In addition, I was able to download the original Parsoid HTML for that old-id, the wikitext for that old-id, edit the HTML locally and verify the table duplication on the command line as follows.

$ node parse --html2wt --selser --oldhtmlfile /tmp/fr.html --oldtextfile /tmp/fr.orig.wt < /tmp/fr.edited.html > /tmp/fr.edited.wt

Investigating ...
Comment 1 ssastry 2013-08-27 21:50:14 UTC
Verified on HTML output generated by latest master (84fac157) -- this rules that that is just a problem with old cached html.
Comment 2 ssastry 2013-08-27 22:18:19 UTC
Traced this to buggy DSR on a paragraph before fostered content. This only happens when a DSR carryign element (like a link) gets fostered out of the table.  The DSR for the paragraph effectively spanned the actual start till the end of the fostered element -- which then causes duplication of table content till that point.
Comment 3 Gerrit Notification Bot 2013-08-27 23:16:49 UTC
Change 81429 had a related patch set uploaded by Subramanya Sastry:
(Bug 53429) Fixed buggy fostered-node handling in DSR computation

https://gerrit.wikimedia.org/r/81429
Comment 4 Gerrit Notification Bot 2013-08-28 01:15:15 UTC
Change 81429 merged by jenkins-bot:
(Bug 53429) Fixed buggy fostered-node handling in DSR computation

https://gerrit.wikimedia.org/r/81429
Comment 5 Guillaume Paumier 2013-08-28 06:02:46 UTC
Awesome. Thank you Subbu :)
Comment 6 ssastry 2013-08-28 16:27:58 UTC
The fix and new code is deployed on production.  However, because of caching reasons, you should make a null wikitext source edit on that page so that the old html is purged from the cache.  On a new VE edit, you should see the fix working without corrupting the page.

We could have purged the cache completely, but we think this problem only affects a small fraction of pages and it seems better to just wait for template changes and wikitext source edits to gradually purge the bad versions.

I am closing this now, but please reopen if the problem isn't fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links