Last modified: 2013-10-16 23:34:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55432, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53432 - Typeof cleanup and smart serialization of new language and interwiki links
Typeof cleanup and smart serialization of new language and interwiki links
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 53505
  Show dependency treegraph
 
Reported: 2013-08-27 22:11 UTC by Gabriel Wicke
Modified: 2013-10-16 23:34 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-08-27 22:11:15 UTC
These currently serialize as external links:

echo '<link rel="mw:WikiLink/Language" href="http://ko.wikipedia.org/wiki/">' | node parse --html2wt
[[http://ko.wikipedia.org/wiki/]]

echo '<a rel="mw:WikiLink/Interwiki" href="http://ko.wikipedia.org/wiki/">ko:</a>' | node parse --html2wt
[[http://ko.wikipedia.org/wiki/|ko:]]

We should probably match absolute URLs against the list of patterns and serialize to the locally defined interwiki / language prefix when that is defined.
Comment 1 Gabriel Wicke 2013-08-27 22:12:56 UTC
https://gerrit.wikimedia.org/r/#/c/81413/ adds tests for this. The html2* portion is currently failing and blacklisted.
Comment 2 Gabriel Wicke 2013-08-28 21:17:32 UTC
DOM spec change plans after some discussion on IRC:

1) mw:WikiLink/Interwiki becomes mw:ExtLink/Interwiki, and we'll automatically detect interwiki prefixes in new/modified mw:ExtLink content.

2) mw:WikiLink/Category becomes mw:PageProp/Category as these are not really links. They don't render at all in the page, don't accept a caption etc.

3) mw:WikiLink/Language becomes mw:PageProp/Language - same as with categories.

We should also revisit the various mw:ExtLink/* variants. Some of them are very syntax-focused without adding real information for external users.
Comment 3 Gerrit Notification Bot 2013-08-28 23:30:47 UTC
Change 81599 had a related patch set uploaded by Catrope:
Add dual detection for types that Parsoid is about to rename

https://gerrit.wikimedia.org/r/81599
Comment 4 Gerrit Notification Bot 2013-08-29 00:55:52 UTC
Change 81599 merged by jenkins-bot:
Add dual detection for types that Parsoid is about to rename

https://gerrit.wikimedia.org/r/81599
Comment 5 James Forrester 2013-08-29 00:56:51 UTC
(In reply to comment #4)
> Change 81599 merged by jenkins-bot:
> Add dual detection for types that Parsoid is about to rename
> 
> https://gerrit.wikimedia.org/r/81599

VE support will be in wmf15 (so deployed on MediaWiki.org tomorrow, and everywhere on 5 September.
Comment 6 Gabriel Wicke 2013-08-29 23:03:44 UTC
In bug 53505 I developed a method for pure-CSS external link numbering ([http://example.com]), so we can also go ahead and simplify all mw:ExtLink/* variants to just mw:ExtLink, and remove the numbering logic in Parsoid. That means that current mw:WikiLink/Interwiki will go straight to mw:ExtLink.
Comment 7 Gerrit Notification Bot 2013-09-19 18:19:30 UTC
Change 84871 had a related patch set uploaded by GWicke:
WIP Bug 53432: DOM spec cleanup

https://gerrit.wikimedia.org/r/84871
Comment 8 Gerrit Notification Bot 2013-10-16 22:58:05 UTC
Change 84871 merged by jenkins-bot:
Bug 53432: DOM spec cleanup

https://gerrit.wikimedia.org/r/84871
Comment 9 Gabriel Wicke 2013-10-16 23:34:20 UTC
This has now landed, but is not yet deployed in production. Will probably go live next week.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links