Last modified: 2013-09-04 02:22:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55444, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53444 - VisualEditor: Metadata should always be collapsed on replace
VisualEditor: Metadata should always be collapsed on replace
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-09-05
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-28 01:12 UTC by C. Scott Ananian
Modified: 2013-09-04 02:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description C. Scott Ananian 2013-08-28 01:12:52 UTC 
In ve.dm.Document.getMetadataReplace(), we only merge metadata if the amount removed is larger than the amount inserted.  But this could end up putting metadata in odd positions, for example if you have Foo[[Category:Bar]]BazQuux and you delete 'ooBa' and replace it with {image}xxx{/image}, then the category ends up inside the image.

We should always merge metadata when a segment is deleted, so that it appears outside any new structure added.
Comment 1 Gerrit Notification Bot 2013-08-30 13:56:14 UTC 
Change 81928 had a related patch set uploaded by Cscott:
Collapse metadata on any removal.

https://gerrit.wikimedia.org/r/81928
Comment 2 Gerrit Notification Bot 2013-09-04 02:22:35 UTC 
Change 81928 merged by jenkins-bot:
Collapse metadata on any removal.

https://gerrit.wikimedia.org/r/81928
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links