Last modified: 2013-09-04 02:23:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55445, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53445 - VisualEditor: Metadata information missing from transaction when content is inserted
VisualEditor: Metadata information missing from transaction when content is i...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-09-05
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-28 01:16 UTC by C. Scott Ananian
Modified: 2013-09-04 02:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description C. Scott Ananian 2013-08-28 01:16:50 UTC 
The final case in ve.dm.Document.getMetadataReplace() applies if insert.length > remove.length.  But in this case only the 'retain' and 'insert' fields are set on the returned object.  In ve.dm.Transaction.pushReplace() we only add the {retain,remove,insert}Metadata fields to the operation if the 'remove' field on the object returned from getMetadataReplace() is not undefined.  So these fields won't be set correctly if insert.length > remove.length.
Comment 1 Gerrit Notification Bot 2013-08-30 13:56:18 UTC 
Change 81928 had a related patch set uploaded by Cscott:
Collapse metadata on any removal.

https://gerrit.wikimedia.org/r/81928
Comment 2 Gerrit Notification Bot 2013-09-04 02:22:33 UTC 
Change 81928 merged by jenkins-bot:
Collapse metadata on any removal.

https://gerrit.wikimedia.org/r/81928
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links