Last modified: 2013-08-29 23:54:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55468, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53468 - Parsoid removed linebreaks in wikitable; <nowikied> some resulting in-cell pipes in a following edit
Parsoid removed linebreaks in wikitable; <nowikied> some resulting in-cell pi...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-28 11:22 UTC by Chris McKenna
Modified: 2013-08-29 23:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-08-28 11:22:23 UTC
In this series of edits Parsoid exhibited strange behaviour:
1. Parsed everything correctly, no problems at all. https://en.wikipedia.org/w/index.php?title=2013_US_Open_%28tennis%29&diff=570482557&oldid=570478151 
2. removed linebreaks in the table, changing:
|{{n/a}}
|{{n/a}}
|{{n/a}}
to:
|{{n/a}}|{{n/a}}|{{n/a}}
https://en.wikipedia.org/w/index.php?title=2013_US_Open_%28tennis%29&diff=570483444&oldid=570482557
3: nowikied the pipes it moved in the previous edit
https://en.wikipedia.org/w/index.php?title=2013_US_Open_%28tennis%29&diff=570484857&oldid=570484805

As far as I can tell, nothing that should make any difference at all happened between 1 and 2 (they were consecutive edits to the page.
Comment 1 ssastry 2013-08-28 15:52:20 UTC
The real error here is the loss of line breaks in step #2.  The nowiki-ing in Step #3 is expected.  So, if #2 is fixed, this will be fine.
Comment 2 Gabriel Wicke 2013-08-28 16:23:07 UTC
This does not seem to be a simple Parsoid issue:

echo -ne '{|\n|{{n/a}}\n|{{n/a}}\n|}' | node parse --wt2wt
{|
|{{n/a}}
|{{n/a}}
|}

Maybe VE dropped the newlines in HTML?
Comment 3 Gabriel Wicke 2013-08-28 16:34:12 UTC
This does actually seem to be a selser issue, probably in the separator handling:

in.txt:
{|
|{{n/a}}
|{{n/a}}
|}

node parse < in.txt > out.html

cat out.html | sed s/a/b/ | node parse --oldtextfile in.txt --oldhtmlfile /tmp/.html --selser --html2wt
{|
|{{n/a}}|{{n/a}}
|}
Comment 4 Gerrit Notification Bot 2013-08-29 01:25:56 UTC
Change 81611 had a related patch set uploaded by GWicke:
Bug 53468: Don't consume trailing IEW when skipping about siblings

https://gerrit.wikimedia.org/r/81611
Comment 5 Gerrit Notification Bot 2013-08-29 02:06:23 UTC
Change 81611 merged by jenkins-bot:
Bug 53468: Don't consume trailing IEW when skipping about siblings

https://gerrit.wikimedia.org/r/81611
Comment 6 Gabriel Wicke 2013-08-29 23:54:55 UTC
Now deployed in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links