Last modified: 2013-10-08 04:57:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55480, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53480 - moving files does not always move transcodes
moving files does not always move transcodes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Jan Gerber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-28 14:56 UTC by Jan Gerber
Modified: 2013-10-08 04:57 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jan Gerber 2013-08-28 14:56:09 UTC
there are some failed transcodes at http://commons.wikimedia.org/wiki/Special:TimedMediaHandler of files that where moved.

transcodes without related video file should not exist.
Comment 1 Sam Reed (reedy) 2013-09-12 04:47:17 UTC
Sometimes? Do they get moved at all?

James F moved https://commons.wikimedia.org/wiki/File:Visual_Editor_Presentation_2013.webm whilst 2 transcodes were still going, but the other 2 had finished.

The 2 finished ones didn't get moved. Should they have been?

I shot the other 2 that were still running (no point letting them finish)
Comment 2 Jan Gerber 2013-09-12 08:25:05 UTC
how was the file moved? on move finished transcodes are deleted and new transcodes are queued for encoding.

But somehow in this case the two transcodes stick around as failed.

The two transcodes listed as failed on https://commons.wikimedia.org/wiki/Special:TimedMediaHandler
are the once that where finished or the once encoding at the time of moving?
Comment 3 Gerrit Notification Bot 2013-09-12 10:20:46 UTC
Change 83996 had a related patch set uploaded by J:
Use TitleMove hook to cleanup transcodes before move

https://gerrit.wikimedia.org/r/83996
Comment 4 Jan Gerber 2013-09-12 10:22:17 UTC
the above change is only useful with https://gerrit.wikimedia.org/r/#/c/83995/ applied to core.
Comment 5 James Forrester 2013-09-12 15:29:40 UTC
(In reply to comment #2)
> how was the file moved?

Special:MovePage

> on move finished transcodes are deleted and new transcodes are queued for
> encoding.

Yes, the queuing up for transcoding worked, but the two completed transcoded files didn't move with the file, which is this bug, I think. If the in-flight transcodes could also be re-directed, that would be excellent, but a different enhancement.
 
> But somehow in this case the two transcodes stick around as failed.

Indeed.

> The two transcodes listed as failed on
> https://commons.wikimedia.org/wiki/Special:TimedMediaHandler
> are the once that where finished or the once encoding at the time of moving?

Those were the ones that were going at the time of the move; they were killed by Sam.
Comment 6 Gerrit Notification Bot 2013-09-23 02:28:45 UTC
Change 83996 merged by jenkins-bot:
Use TitleMove hook to cleanup transcodes before move

https://gerrit.wikimedia.org/r/83996
Comment 7 Andre Klapper 2013-10-03 16:52:05 UTC
(In reply to comment #4)
> the above change is only useful with
> https://gerrit.wikimedia.org/r/#/c/83995/
> applied to core.

That patch got merged into Core two weeks ago, and patch in comment 3 got also merged ten days ago.

Jan: Can this report be closed as RESOLVED FIXED, or is more work needed?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links