Last modified: 2014-11-08 01:50:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55490, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53490 - Echo: Fix "Invalid CSS property value" for text-shadow
Echo: Fix "Invalid CSS property value" for text-shadow
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-28 17:52 UTC by Krinkle
Modified: 2014-11-08 01:50 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Composition is current (top left), space fixed (bottom right), value fixed (top right) (769.24 KB, image/png)
2013-08-28 17:52 UTC, Krinkle
Details

Description Krinkle 2013-08-28 17:52:46 UTC
Created attachment 13192 [details]
Composition is current (top left), space fixed (bottom right), value fixed (top right)

The text-shadow for mw-echo-notifications-badge has an invalid value, as a result the style is ignored and not rendered.

The value is invalid because it contains a non-breaking space, which is not allowed.

The value is also missing a leading 0 (it should have 3 dimension values, 2 works (as demonstrated in the screenshot) but is probably not what you want).

See attached screenshot for:
* Current value, and rendering thereof (no shadow because value is invalid)
* What it would look like with the space fixed (0 1px shadow)
* What it would look like with the value fixed (0 0 1px shadow)
Comment 1 Gerrit Notification Bot 2013-08-28 17:55:31 UTC
Change 81529 had a related patch set uploaded by Krinkle:
badge: Fix invalid CSS value for text-shadow

https://gerrit.wikimedia.org/r/81529
Comment 2 Gerrit Notification Bot 2013-08-29 19:40:35 UTC
Change 81502 had a related patch set uploaded by Matmarex:
ext.echo.badge: Remove defunct CSS rule

https://gerrit.wikimedia.org/r/81502
Comment 3 Gerrit Notification Bot 2013-08-30 04:05:37 UTC
Change 81502 merged by jenkins-bot:
ext.echo.badge: Remove defunct CSS rule

https://gerrit.wikimedia.org/r/81502
Comment 4 Bartosz Dziewoński 2013-09-04 16:02:05 UTC
This was fixed by my patch (which I submitted completely independently, I swear).
Comment 5 Gerrit Notification Bot 2013-09-04 16:02:33 UTC
Change 81529 abandoned by Matmarex:
badge: Fix invalid CSS value for text-shadow

Reason:
This was fixed by my patch https://gerrit.wikimedia.org/r/81502 (which I submitted completely independently, I swear).

https://gerrit.wikimedia.org/r/81529

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links