Last modified: 2013-09-03 23:29:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55492, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53492 - data-mw attribute is stripped out of parsoid tests
data-mw attribute is stripped out of parsoid tests
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-28 19:35 UTC by Christian Williams
Modified: 2013-09-03 23:29 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christian Williams 2013-08-28 19:35:40 UTC 
In mediawiki.Util.js:911, the attribute data-mw is being stripped out. The !parsoidOnly path correctly strips the attribute, but the 'else' path erroneously strips it.

A quick test of fixing line 911 broke about 150 tests. These tests should be updated to expect the data-mw attribute.
Comment 1 ssastry 2013-08-29 16:33:20 UTC 
Turns out this is not that bad as feared. About 29 tests require their results updated (accounting for 150 test failures in all modes). Most of the fixes required are from the data-mw patch I pushed a few days back -- of course, I forgot to update tests and we didn't catch it because data-mw was being stripped. On it now.
Comment 2 Gerrit Notification Bot 2013-09-03 21:05:57 UTC 
Change 82521 had a related patch set uploaded by Subramanya Sastry:
(Bug 53492) Updated tests + code to not strip data-mw in parsoid mode

https://gerrit.wikimedia.org/r/82521
Comment 3 Gerrit Notification Bot 2013-09-03 22:43:42 UTC 
Change 82521 merged by jenkins-bot:
(Bug 53492) Updated tests + code to not strip data-mw in parsoid mode

https://gerrit.wikimedia.org/r/82521
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links